Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 084a6d4d authored by Lucas Dupin's avatar Lucas Dupin
Browse files

Do not blur opaque layers 

If a layer is opaque, there's no reason to send it to client composition
due to blurs.

Bug: 196828055
Test: atest OutputUpdateAndWriteCompositionStateTest
Test: atest OutputComposeSurfacesTest_SetsExpensiveRendering_ForBlur
Test: perfetto trace
Change-Id: I55461cbad0008351c15e7dd8d2da20e0b1c59f70
parent 5bfe8343

services/surfaceflinger/CompositionEngine/src/Output.cpp

+3 −0
Original line number Diff line number Diff line
@@ -789,6 +789,9 @@ compositionengine::OutputLayer* Output::findLayerRequestingBackgroundComposition 
        if (compState->sidebandStream != nullptr) {

            return nullptr;

        }

        if (compState->isOpaque) {

            continue;

        }

        if (compState->backgroundBlurRadius > 0 || compState->blurRegions.size() > 0) {

            layerRequestingBgComposition = layer;

        }

services/surfaceflinger/CompositionEngine/tests/OutputTest.cpp

+34 −0
Original line number Diff line number Diff line
@@ -3606,6 +3606,7 @@ struct OutputComposeSurfacesTest_SetsExpensiveRendering_ForBlur 
      : public OutputComposeSurfacesTest_SetsExpensiveRendering {

    OutputComposeSurfacesTest_SetsExpensiveRendering_ForBlur() {

        mLayer.layerFEState.backgroundBlurRadius = 10;

        mLayer.layerFEState.isOpaque = false;

        mOutput.editState().isEnabled = true;



        EXPECT_CALL(mLayer.outputLayer, updateCompositionState(false, true, ui::Transform::ROT_0));
@@ -4225,6 +4226,37 @@ TEST_F(GenerateClientCompositionRequestsTest_ThreeLayers, 
                                                                kDisplayDataspace));

}



TEST_F(OutputUpdateAndWriteCompositionStateTest, noBackgroundBlurWhenOpaque) {

    InjectedLayer layer1;

    InjectedLayer layer2;



    uint32_t z = 0;

    // Layer requesting blur, or below, should request client composition, unless opaque.

    EXPECT_CALL(*layer1.outputLayer, updateCompositionState(false, false, ui::Transform::ROT_0));

    EXPECT_CALL(*layer1.outputLayer,

                writeStateToHWC(/*includeGeometry*/ false, /*skipLayer*/ false, z++,

                                /*zIsOverridden*/ false, /*isPeekingThrough*/ false));

    EXPECT_CALL(*layer2.outputLayer, updateCompositionState(false, false, ui::Transform::ROT_0));

    EXPECT_CALL(*layer2.outputLayer,

                writeStateToHWC(/*includeGeometry*/ false, /*skipLayer*/ false, z++,

                                /*zIsOverridden*/ false, /*isPeekingThrough*/ false));



    layer2.layerFEState.backgroundBlurRadius = 10;

    layer2.layerFEState.isOpaque = true;



    injectOutputLayer(layer1);

    injectOutputLayer(layer2);



    mOutput->editState().isEnabled = true;



    CompositionRefreshArgs args;

    args.updatingGeometryThisFrame = false;

    args.devOptForceClientComposition = false;

    mOutput->updateCompositionState(args);

    mOutput->planComposition();

    mOutput->writeCompositionState(args);

}



TEST_F(OutputUpdateAndWriteCompositionStateTest, handlesBackgroundBlurRequests) {

    InjectedLayer layer1;

    InjectedLayer layer2;
@@ -4246,6 +4278,7 @@ TEST_F(OutputUpdateAndWriteCompositionStateTest, handlesBackgroundBlurRequests) 
                                /*zIsOverridden*/ false, /*isPeekingThrough*/ false));



    layer2.layerFEState.backgroundBlurRadius = 10;

    layer2.layerFEState.isOpaque = false;



    injectOutputLayer(layer1);

    injectOutputLayer(layer2);
@@ -4283,6 +4316,7 @@ TEST_F(OutputUpdateAndWriteCompositionStateTest, handlesBlurRegionRequests) { 


    BlurRegion region;

    layer2.layerFEState.blurRegions.push_back(region);

    layer2.layerFEState.isOpaque = false;



    injectOutputLayer(layer1);

    injectOutputLayer(layer2);