Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba8e6d36 authored by Schneider Victor-tulias's avatar Schneider Victor-tulias
Browse files

Fix launcher crash loop. 

A null title in a cache entry causes a crash loop, however this title is necessary. Without the title, there is no point to caching the entry. Added logging and removed the null check to catch future errors.

Test: started launcher with a forced null title and without.
Bug: 210847986

Change-Id: Ief8be84254f3115aa4fa288171e8242953f39cd4
parent b8f261a3

iconloaderlib/src/com/android/launcher3/icons/cache/BaseIconCache.java

+7 −1
Original line number Diff line number Diff line
@@ -261,7 +261,13 @@ public abstract class BaseIconCache { 
        // (e.g. fallback icon, default icon). So we drop here since there's no point in caching

        // an empty entry.

        if (entry.bitmap.isNullOrLowRes()) return;

        entry.title = cachingLogic.getLabel(object);



        CharSequence entryTitle = cachingLogic.getLabel(object);

        if (entryTitle == null) {

            Log.d(TAG, "No label returned from caching logic instance: " + cachingLogic);

        }

        entry.title = entryTitle;



        entry.contentDescription = mPackageManager.getUserBadgedLabel(entry.title, user);

        if (cachingLogic.addToMemCache()) mCache.put(key, entry);