Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffda8be6 authored by Franciszek Juras's avatar Franciszek Juras
Browse files

Add improveLargeScreenInteractionOnLockscreen config parameter 

Reasoning behind this is that on large-screen form factors,
independent of whether mouse or touch is the primary input,
some screen interactions change, for example:
- input buttons don't need to be close to the edge for easy
one-handed input,
- swiping is less convenient for navigation
(e.g. going to the previous screen).

Add repository and interactor methods to read the parameter.

For CL enabling this config for desktop see: ag/33553437

Test: manual
Bug: 416223998
Flag: EXEMPT config change
Change-Id: Ie2ffb09c1631d6f60e0b47c00b551ebf3f0dc147
parent 795d133e

packages/SystemUI/res/values/config.xml

+3 −0
Original line number Diff line number Diff line
@@ -1134,4 +1134,7 @@ 


    <!-- If AOD can show an ambient version of the wallpaper (-1 means ignore) -->

    <integer name="config_dozeSupportsAodWallpaperOverride">-1</integer>



    <!-- Whether to enable features improving large screen interaction -->

    <bool name="config_improveLargeScreenInteractionOnLockscreen">false</bool>

</resources>

packages/SystemUI/src/com/android/systemui/bouncer/data/repository/BouncerRepository.kt

+7 −0
Original line number Diff line number Diff line
@@ -50,6 +50,13 @@ constructor( 
    val isOneHandedBouncerSupportedInConfig: Boolean

        get() = applicationContext.resources.getBoolean(R.bool.can_use_one_handed_bouncer)



    /** Whether improved large screen interaction is enabled for this device */

    val isImproveLargeScreenInteractionEnabledInConfig: Boolean

        get() =

            applicationContext.resources.getBoolean(

                R.bool.config_improveLargeScreenInteractionOnLockscreen

            )



    /**

     * Preferred side of the screen where the input area on the bouncer should be. This is

     * applicable for large screen devices (foldables and tablets).

packages/SystemUI/src/com/android/systemui/bouncer/domain/interactor/BouncerInteractor.kt

+4 −0
Original line number Diff line number Diff line
@@ -117,6 +117,10 @@ constructor( 
                (repository.isOneHandedBouncerSupportedInConfig && (authMethod !is Password))

        }



    /** Whether interactions should be improved for large-screen (non-handheld) form factor. */

    val isImproveLargeScreenInteractionEnabled: Boolean =

        repository.isImproveLargeScreenInteractionEnabledInConfig



    /**

     * Preferred side of the screen where the input area on the bouncer should be. This is

     * applicable for large screen devices (foldables and tablets).