Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffcf558a authored by Weng Su's avatar Weng Su
Browse files

[Provider Model] Refine sub-title (QS Internet Dialog) 

- Show "No other networks available" when W+ connected only without
other WiFi networks

- See b/207470178#comment14 for a screenshot.

Bug: 207470178
Test: manual test
atest -c InternetDialogControllerTest

Change-Id: I7d2b5672d8e56b23aa81c1bc291abc2406b85287
parent 535795b3

packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialogController.java

+4 −0
Original line number Diff line number Diff line
@@ -348,6 +348,10 @@ public class InternetDialogController implements AccessPointController.AccessPoi 
            return mContext.getText(SUBTITLE_TEXT_SEARCHING_FOR_NETWORKS);

        }



        if (isCarrierNetworkActive()) {

            return mContext.getText(SUBTITLE_TEXT_NON_CARRIER_NETWORK_UNAVAILABLE);

        }



        // Sub-Title:

        // show non_carrier_network_unavailable

        //   - while Wi-Fi on + no Wi-Fi item

packages/SystemUI/tests/src/com/android/systemui/qs/tiles/dialog/InternetDialogControllerTest.java

+11 −1
Original line number Diff line number Diff line
@@ -159,7 +159,6 @@ public class InternetDialogControllerTest extends SysuiTestCase { 
        mAccessPoints.add(mWifiEntry1);

        when(mAccessPointController.getMergedCarrierEntry()).thenReturn(mMergedCarrierEntry);

        when(mSubscriptionManager.getActiveSubscriptionIdList()).thenReturn(new int[]{SUB_ID});

        when(mAccessPointController.getMergedCarrierEntry()).thenReturn(mMergedCarrierEntry);

        when(mToastFactory.createToast(any(), anyString(), anyString(), anyInt(), anyInt()))

            .thenReturn(mSystemUIToast);

        when(mSystemUIToast.getView()).thenReturn(mToastView);
@@ -334,6 +333,17 @@ public class InternetDialogControllerTest extends SysuiTestCase { 
                .isNotEqualTo(getResourcesString("non_carrier_network_unavailable"));

    }



    @Test

    public void getSubtitleText_withCarrierNetworkActiveOnly_returnNoOtherAvailable() {

        fakeAirplaneModeEnabled(false);

        when(mWifiManager.isWifiEnabled()).thenReturn(true);

        mInternetDialogController.onAccessPointsChanged(null /* accessPoints */);

        when(mMergedCarrierEntry.isDefaultNetwork()).thenReturn(true);



        assertThat(mInternetDialogController.getSubtitleText(false))

                .isEqualTo(getResourcesString("non_carrier_network_unavailable"));

    }



    @Test

    public void getWifiDetailsSettingsIntent_withNoKey_returnNull() {

        assertThat(mInternetDialogController.getWifiDetailsSettingsIntent(null)).isNull();