Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffcc9769 authored by Daniel Sandler's avatar Daniel Sandler
Browse files

Temporarily restore some support for icon==0 notifications. 

This is WRONG WRONG WRONG but certain apps rely on it to
poke the LED and so forth. In a future release this will
stop working.

Bug: 8623399
Change-Id: I49bb8ccc6891b1398ceec94c64d6c3a510ad1c38
parent c037282c

services/java/com/android/server/NotificationManagerService.java

+4 −2
Original line number Diff line number Diff line
@@ -1682,7 +1682,7 @@ public class NotificationManagerService extends INotificationManager.Stub 


                notifyPostedLocked(r);

            } else {

                Slog.e(TAG, "Ignoring notification with icon==0: " + notification);

                Slog.e(TAG, "Not posting notification with icon==0: " + notification);

                if (old != null && old.statusBarKey != null) {

                    long identity = Binder.clearCallingIdentity();

                    try {
@@ -1694,7 +1694,9 @@ public class NotificationManagerService extends INotificationManager.Stub 


                    notifyRemovedLocked(r);

                }

                return; // do not play sounds, show lights, etc. for invalid notifications

                // ATTENTION: in a future release we will bail out here

                // so that we do not play sounds, show lights, etc. for invalid notifications

                Slog.e(TAG, "WARNING: In a future release this will crash the app: " + n.getPackageName());

            }



            // If we're not supposed to beep, vibrate, etc. then don't.