Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff83b0e4 authored by Chalard Jean's avatar Chalard Jean
Browse files

[NS D07] Use the unmodified legacy score 

Ranking used to make use of the various adjustments in
ConnectivityService. These are now implemented in policy.

Test: ConnectivityServiceTest

Change-Id: I56109847678ea5cda1752511123ba652c0f4fe36
parent e9fd5a72

services/core/java/com/android/server/connectivity/NetworkRanker.java

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ public class NetworkRanker { 
        NetworkAgentInfo bestNetwork = null;

        int bestScore = Integer.MIN_VALUE;

        for (final NetworkAgentInfo nai : candidates) {

            final int score = nai.getCurrentScore();

            final int score = nai.getNetworkScore().getLegacyScore();

            if (score > bestScore) {

                bestNetwork = nai;

                bestScore = score;

tests/net/java/com/android/server/ConnectivityServiceTest.java

+1 −1
Original line number Diff line number Diff line
@@ -5846,7 +5846,7 @@ public class ConnectivityServiceTest { 


        mWiFiNetworkAgent = new TestNetworkAgentWrapper(TRANSPORT_WIFI);

        mWiFiNetworkAgent.connect(true);

        trustedCallback.expectAvailableDoubleValidatedCallbacks(mWiFiNetworkAgent);

        trustedCallback.expectAvailableThenValidatedCallbacks(mWiFiNetworkAgent);

        verify(mNetworkManagementService).setDefaultNetId(eq(mWiFiNetworkAgent.getNetwork().netId));

        reset(mNetworkManagementService);

tests/net/java/com/android/server/connectivity/NetworkRankerTest.kt

+0 −2
Original line number Diff line number Diff line
@@ -28,8 +28,6 @@ import androidx.test.filters.SmallTest 
import androidx.test.runner.AndroidJUnit4

import org.junit.Test

import org.junit.runner.RunWith

import org.mockito.ArgumentMatchers.any

import org.mockito.Mockito.doReturn

import org.mockito.Mockito.mock

import kotlin.test.assertEquals

import kotlin.test.assertNull