Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff37ce97 authored by Leon Scroggins III's avatar Leon Scroggins III
Browse files

Call isEmpty() instead of constructing a new object to compare 

A recent change in Skia
(https://skia-review.googlesource.com/c/skia/+/573636) moves operator==
into the cpp file, where this file cannot access it due to libhwui's map
file. Call isEmpty, which is still in the header file, and skips
unnecessary creation of a new object anyway.

Bug: NA
Test: AImageDecoderTest
Change-Id: I1dec89a38e248138ace364e8cb7259eb777e8871
parent c6fbc786

native/graphics/jni/imagedecoder.cpp

+1 −1
Original line number Diff line number Diff line
@@ -381,7 +381,7 @@ int AImageDecoder_setCrop(AImageDecoder* decoder, ARect crop) { 


    SkIRect cropIRect;

    cropIRect.setLTRB(crop.left, crop.top, crop.right, crop.bottom);

    SkIRect* cropPtr = cropIRect == SkIRect::MakeEmpty() ? nullptr : &cropIRect;

    SkIRect* cropPtr = cropIRect.isEmpty() ? nullptr : &cropIRect;

    return imageDecoder->setCropRect(cropPtr)

            ? ANDROID_IMAGE_DECODER_SUCCESS : ANDROID_IMAGE_DECODER_BAD_PARAMETER;

}