Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit febab8c3 authored by Ilya Matyukhin's avatar Ilya Matyukhin
Browse files

Fix NPE in *GenerateChallengeClient 

Bug: 191989346
Bug: 191684201
Test: N/A
Change-Id: I72e59aa8756f44b332ed5b18e248871baae105ed
parent 27b63bb1

services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceGenerateChallengeClient.java

+7 −1
Original line number Diff line number Diff line
@@ -52,7 +52,13 @@ public class FaceGenerateChallengeClient extends GenerateChallengeClient<ISessio 


    void onChallengeGenerated(int sensorId, int userId, long challenge) {

        try {

            getListener().onChallengeGenerated(sensorId, userId, challenge);

            final ClientMonitorCallbackConverter listener = getListener();

            if (listener == null) {

                Slog.e(TAG, "Listener is null in onChallengeGenerated");

                mCallback.onClientFinished(this, false /* success */);

                return;

            }

            listener.onChallengeGenerated(sensorId, userId, challenge);

            mCallback.onClientFinished(this, true /* success */);

        } catch (RemoteException e) {

            Slog.e(TAG, "Unable to send challenge", e);

services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintGenerateChallengeClient.java

+7 −1
Original line number Diff line number Diff line
@@ -53,7 +53,13 @@ class FingerprintGenerateChallengeClient extends GenerateChallengeClient<ISessio 


    void onChallengeGenerated(int sensorId, int userId, long challenge) {

        try {

            getListener().onChallengeGenerated(sensorId, userId, challenge);

            final ClientMonitorCallbackConverter listener = getListener();

            if (listener == null) {

                Slog.e(TAG, "Listener is null in onChallengeGenerated");

                mCallback.onClientFinished(this, false /* success */);

                return;

            }

            listener.onChallengeGenerated(sensorId, userId, challenge);

            mCallback.onClientFinished(this, true /* success */);

        } catch (RemoteException e) {

            Slog.e(TAG, "Unable to send challenge", e);