Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe6c9dfd authored by Felipe Leme's avatar Felipe Leme Committed by Android (Google) Code Review
Browse files

Merge "Fixed obsolete TODOs."

parents d3e68457 104b932b

core/java/android/os/storage/StorageVolume.java

+1 −2
Original line number Diff line number Diff line
@@ -373,8 +373,7 @@ public final class StorageVolume implements Parcelable { 
    }



    /** {@hide} */

    // TODO(b/26742218): find out where toString() is called internally and replace these calls by

    // dump().

    // TODO: find out where toString() is called internally and replace these calls by dump().

    public String dump() {

        final CharArrayWriter writer = new CharArrayWriter();

        dump(new IndentingPrintWriter(writer, "    ", 80));

core/java/android/service/autofill/AutofillServiceInfo.java

+0 −2
Original line number Diff line number Diff line
@@ -78,14 +78,12 @@ public final class AutofillServiceInfo { 
            // TODO(b/35956626): inline newSettingsActivity once clients migrate

            final String newSettingsActivity =

                    metaDataArray.getString(R.styleable.AutofillService_settingsActivity);

            System.out.println(">>> NEW CRAP MAN: " + newSettingsActivity); // TODO(felipeal): tmp

            if (newSettingsActivity != null) {

                mSettingsActivity = newSettingsActivity;

            } else {

                mSettingsActivity =

                        metaDataArray.getString(R.styleable.AutoFillService_settingsActivity);

            }

            System.out.println(">>> FINAL CRAP MAN: " + mSettingsActivity); // TODO(felipeal): tmp

            metaDataArray.recycle();

        } else {

            mSettingsActivity = null;

services/autofill/java/com/android/server/autofill/RemoteFillService.java

+2 −2
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ final class RemoteFillService implements DeathRecipient { 
        }

        mBinding = false;

        if (isBound()) {

            // TODO(b/33197203, b/35395043): synchronize access instead

            // TODO(b/33197203): synchronize access instead?

            // Need to double check if it's null, since it could be set on onServiceDisconnected()

            if (mAutoFillService != null) {

                try {
@@ -322,7 +322,7 @@ final class RemoteFillService implements DeathRecipient { 
            }



            try {

                // TODO(b/33197203, b/35395043): synchronize access instead

                // TODO(b/33197203): synchronize access instead?

                // Need to double check if it's null, since it could be set on

                // onServiceDisconnected()

                if (mAutoFillService != null) {