Optimize AppOpsManager.getFormattedStackTrace

Avoid redundant toString() calls for a given StackTraceElement when
fetching the formatted stack trace for an Op. This call is not trivially
cheap, and shows up in system stack samples, so make sure it only
happens once.

Bug: 308786093
Test: m + presubmit
Change-Id: I463addc4995b1553ff4b22e712208557ab4a663c

parent 3397af24

core/java/android/app/AppOpsManager.java

+3 −2

Original line number	Diff line number	Diff line
		@@ -9931,10 +9931,11 @@ public class AppOpsManager {
		if (i != firstInteresting) {
		sb.append('\n');
		}
		if (!sFullLog && sb.length() + trace[i].toString().length() > 600) {
		final String traceString = trace[i].toString();
		if (!sFullLog && sb.length() + traceString.length() > 600) {
		break;
		}
		sb.append(trace[i]);
		sb.append(traceString);
		}

		return sb.toString();