Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdbcf17a authored by MahendaviAamir's avatar MahendaviAamir Committed by Sudheer Shanka
Browse files

Send targeted broadcasts to prevent other apps from receiving them. 

When sending broadcasts ACTION_SNOOZE_WARNING in NPMS, which may
contain sensitive information, explicitly set the package name
that should receive it to prevent other apps from receiving them.

Bug: 177931370
Test: manual
Change-Id: I2a0a0dc09e27791de829bacfb2e865ffea993715
Merged-In: I11d736771d859d2af27d5c84a502ab038974e2e2
parent 1692babe

services/core/java/com/android/server/net/NetworkPolicyManagerService.java

+4 −3
Original line number Diff line number Diff line
@@ -1155,8 +1155,8 @@ public class NetworkPolicyManagerService extends INetworkPolicyManager.Stub { 
                builder.setContentText(body);

                builder.setDefaults(Notification.DEFAULT_ALL);

                builder.setChannelId(SystemNotificationChannels.NETWORK_ALERTS);



                final Intent snoozeIntent = buildSnoozeWarningIntent(policy.template);

                final Intent snoozeIntent = buildSnoozeWarningIntent(policy.template,

                        mContext.getPackageName());

                builder.setDeleteIntent(PendingIntent.getBroadcast(

                        mContext, 0, snoozeIntent, PendingIntent.FLAG_UPDATE_CURRENT));
@@ -4243,9 +4243,10 @@ public class NetworkPolicyManagerService extends INetworkPolicyManager.Stub { 
        return new Intent(ACTION_ALLOW_BACKGROUND);

    }



    private static Intent buildSnoozeWarningIntent(NetworkTemplate template) {

    private static Intent buildSnoozeWarningIntent(NetworkTemplate template, String targetPackage) {

        final Intent intent = new Intent(ACTION_SNOOZE_WARNING);

        intent.putExtra(EXTRA_NETWORK_TEMPLATE, template);

        intent.setPackage(targetPackage);

        return intent;

    }