Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd48ed66 authored by Vladislav Kaznacheev's avatar Vladislav Kaznacheev
Browse files

Fix VideoView touch and trackball handlers to call super. 

Currently VideoView.onTouchEvent and VideoView.onTrackballEvent do not
call super. This completely disables several useful View features
such as long click, context menu or tooltips.

Bug: 37755662
Test: manual
Change-Id: I0c82c32da36e4ca7cacc78027daed2fa298a6b58
parent af12b176

core/java/android/widget/VideoView.java

+6 −4
Original line number Diff line number Diff line
@@ -708,18 +708,20 @@ public class VideoView extends SurfaceView 


    @Override

    public boolean onTouchEvent(MotionEvent ev) {

        if (isInPlaybackState() && mMediaController != null) {

        if (ev.getAction() == MotionEvent.ACTION_DOWN

                && isInPlaybackState() && mMediaController != null) {

            toggleMediaControlsVisiblity();

        }

        return false;

        return super.onTouchEvent(ev);

    }



    @Override

    public boolean onTrackballEvent(MotionEvent ev) {

        if (isInPlaybackState() && mMediaController != null) {

        if (ev.getAction() == MotionEvent.ACTION_DOWN

                && isInPlaybackState() && mMediaController != null) {

            toggleMediaControlsVisiblity();

        }

        return false;

        return super.onTrackballEvent(ev);

    }



    @Override