Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc530407 authored by felipeal's avatar felipeal
Browse files

Fixed when SystemServerInitThreadPool.shutdown() is called. 

The class' Javadoc says it's shut down after P HASE_BOOT_COMPLETED, whic was
not the case.

Test: manual verification / boot
Fixes: 156257347

Change-Id: I3c8b24c6855c7c83cdf1eacc637b8e064a121fe3
parent 5d92729c

services/core/java/com/android/server/SystemServerInitThreadPool.java

+3 −1
Original line number Diff line number Diff line
@@ -133,9 +133,11 @@ public class SystemServerInitThreadPool { 
    /**

     * Shuts it down.

     *

     * <p>Note:</p> should only be called by {@link SystemServer}.

     * <p>Note:</p> should only be called *after* {@code PHASE_BOOT_COMPLETED} is sent to the

     * {@link SystemService system services}.

     */

    static void shutdown() {

        Slog.d(TAG, "Shutdown requested");

        synchronized (LOCK) {

            TimingsTraceAndSlog t = new TimingsTraceAndSlog();

            t.traceBegin("WaitInitThreadPoolShutdown");

services/core/java/com/android/server/SystemServiceManager.java

+1 −0
Original line number Diff line number Diff line
@@ -222,6 +222,7 @@ public class SystemServiceManager { 
        if (phase == SystemService.PHASE_BOOT_COMPLETED) {

            final long totalBootTime = SystemClock.uptimeMillis() - mRuntimeStartUptime;

            t.logDuration("TotalBootTime", totalBootTime);

            SystemServerInitThreadPool.shutdown();

        }

    }

services/java/com/android/server/SystemServer.java

+0 −1
Original line number Diff line number Diff line
@@ -590,7 +590,6 @@ public final class SystemServer { 
            startBootstrapServices(t);

            startCoreServices(t);

            startOtherServices(t);

            SystemServerInitThreadPool.shutdown();

        } catch (Throwable ex) {

            Slog.e("System", "******************************************");

            Slog.e("System", "************ Failure starting system services", ex);