Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc00db0a authored by Daniel Kim's avatar Daniel Kim Committed by Android (Google) Code Review
Browse files

Revert "Include invisible parent layouts in assistStructure" 

Revert submission 24735159-invisible_layout

Reason for revert: possible regression in AwG truth data processor. Will re-raise under a flag

Reverted changes: /q/submissionid:24735159-invisible_layout

Change-Id: I651d687835754ba3b8a0dfd488831b044f8a9f8b
parent 5792376f

core/java/android/view/ViewGroup.java

+1 −9
Original line number Diff line number Diff line
@@ -3752,15 +3752,7 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager 
                        && !child.isActivityDeniedForAutofillForUnimportantView())

                    || (shouldIncludeAllChildrenViewWithAutofillTypeNotNone(afm)

                        && child.getAutofillType() != AUTOFILL_TYPE_NONE)

                    || shouldIncludeAllChildrenViews(afm)

                    || (child instanceof ViewGroup && child.getVisibility() != View.VISIBLE)) {

                // If the child is a ViewGroup object and its visibility is not visible, include

                // it as part of the assist structure. The children of these invisible ViewGroup

                // objects are parsed and included in the assist structure. When the Autofill

                // Provider determines the visibility of these children, it looks at their

                // visibility as well as their parent's visibility. Omitting invisible parents

                // will lead to the Autofill Provider incorrectly assuming that these children

                // of invisible parents are actually visible.

                    || shouldIncludeAllChildrenViews(afm)){

                list.add(child);

            } else if (child instanceof ViewGroup) {

                ((ViewGroup) child).populateChildrenForAutofill(list, flags);