Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb578b6b authored by Eric Laurent's avatar Eric Laurent Committed by Android (Google) Code Review
Browse files

Merge "audioflinger: fix clicks on 48kHz audio." into ics-mr1

parents c8810c2f 72dafb20

services/audioflinger/AudioFlinger.cpp

+9 −1
Original line number Original line Diff line number Diff line
@@ -2111,7 +2111,15 @@ uint32_t AudioFlinger::MixerThread::prepareTracks_l(const SortedVector< wp<Track 
            if (t->sampleRate() == (int)mSampleRate) {

            if (t->sampleRate() == (int)mSampleRate) {

                minFrames = mFrameCount;

                minFrames = mFrameCount;

            } else {

            } else {

                minFrames = (mFrameCount * t->sampleRate()) / mSampleRate + 1;

                // +1 for rounding and +1 for additional sample needed for interpolation

                minFrames = (mFrameCount * t->sampleRate()) / mSampleRate + 1 + 1;

                // add frames already consumed but not yet released by the resampler

                // because cblk->framesReady() will  include these frames

                minFrames += mAudioMixer->getUnreleasedFrames(track->name());

                // the minimum track buffer size is normally twice the number of frames necessary

                // to fill one buffer and the resampler should not leave more than one buffer worth

                // of unreleased frames after each pass, but just in case...

                LOG_ASSERT(minFrames <= cblk->frameCount);

            }

            }

        }

        }

        if ((cblk->framesReady() >= minFrames) && track->isReady() &&

        if ((cblk->framesReady() >= minFrames) && track->isReady() &&

services/audioflinger/AudioMixer.cpp

+17 −0
Original line number Original line Diff line number Diff line
@@ -331,6 +331,23 @@ void AudioMixer::track_t::adjustVolumeRamp(bool aux) 
    }

    }

}

}





size_t AudioMixer::track_t::getUnreleasedFrames()

{

    if (resampler != NULL) {

        return resampler->getUnreleasedFrames();

    }

    return 0;

}



size_t AudioMixer::getUnreleasedFrames(int name)

{

    name -= TRACK0;

    if (uint32_t(name) < MAX_NUM_TRACKS) {

        track_t& track(mState.tracks[name]);

        return track.getUnreleasedFrames();

    }

    return 0;

}





status_t AudioMixer::setBufferProvider(AudioBufferProvider* buffer)

status_t AudioMixer::setBufferProvider(AudioBufferProvider* buffer)

{

{

services/audioflinger/AudioMixer.h

+3 −0
Original line number Original line Diff line number Diff line
@@ -91,6 +91,8 @@ public: 




    static void ditherAndClamp(int32_t* out, int32_t const *sums, size_t c);

    static void ditherAndClamp(int32_t* out, int32_t const *sums, size_t c);





    size_t      getUnreleasedFrames(int name);



private:

private:





    enum {

    enum {
@@ -167,6 +169,7 @@ private: 
        bool        doesResample() const;

        bool        doesResample() const;

        void        resetResampler();

        void        resetResampler();

        void        adjustVolumeRamp(bool aux);

        void        adjustVolumeRamp(bool aux);

        size_t      getUnreleasedFrames();

    };

    };





    // pad to 32-bytes to fill cache line

    // pad to 32-bytes to fill cache line

services/audioflinger/AudioResampler.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -54,6 +54,7 @@ public: 
            AudioBufferProvider* provider) = 0;

            AudioBufferProvider* provider) = 0;





    virtual void reset();

    virtual void reset();

    virtual size_t getUnreleasedFrames() { return mInputIndex; }





protected:

protected:

    // number of bits for phase fraction - 30 bits allows nearly 2x downsampling

    // number of bits for phase fraction - 30 bits allows nearly 2x downsampling