Merge "SharedMemory: mark fdsan ownership" into main (fb519c5d) · Commits · e / os / android_frameworks_base

core/java/android/os/SharedMemory.java

+9 −8

Original line number	Diff line number	Diff line
		@@ -25,6 +25,8 @@ import android.system.OsConstants;

		import dalvik.system.VMRuntime;

		import libcore.io.IoUtils;

		import java.io.Closeable;
		import java.io.FileDescriptor;
		import java.io.IOException;
		@@ -63,7 +65,7 @@ public final class SharedMemory implements Parcelable, Closeable {

		mMemoryRegistration = new MemoryRegistration(mSize);
		mCleaner = Cleaner.create(mFileDescriptor,
		new Closer(mFileDescriptor.getInt$(), mMemoryRegistration));
		new Closer(mFileDescriptor, mMemoryRegistration));
		}

		/**
		@@ -326,21 +328,20 @@ public final class SharedMemory implements Parcelable, Closeable {
		* Cleaner that closes the FD
		*/
		private static final class Closer implements Runnable {
		private int mFd;
		private FileDescriptor mFd;
		private MemoryRegistration mMemoryReference;

		private Closer(int fd, MemoryRegistration memoryReference) {
		private Closer(FileDescriptor fd, MemoryRegistration memoryReference) {
		mFd = fd;
		IoUtils.setFdOwner(mFd, this);
		mMemoryReference = memoryReference;
		}

		@Override
		public void run() {
		try {
		FileDescriptor fd = new FileDescriptor();
		fd.setInt$(mFd);
		Os.close(fd);
		} catch (ErrnoException e) { /* swallow error */ }
		IoUtils.closeQuietly(mFd);
		mFd = null;

		mMemoryReference.release();
		mMemoryReference = null;
		}

+1 −1

Original line number	Diff line number	Diff line
		@@ -87,7 +87,7 @@ public class ContentResolverTest {
		bitmap.compress(Bitmap.CompressFormat.PNG, 90, mImage.getOutputStream());

		final AssetFileDescriptor afd = new AssetFileDescriptor(
		new ParcelFileDescriptor(mImage.getFileDescriptor()), 0, mSize, null);
		ParcelFileDescriptor.dup(mImage.getFileDescriptor()), 0, mSize, null);
		when(mProvider.openTypedAssetFile(any(), any(), any(), any(), any())).thenReturn(
		afd);
		}