Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fad70831 authored by Riddle Hsu's avatar Riddle Hsu
Browse files

Remove enabled flag filter_irrelevant_input_device_change 

It is enabled since previous release.

Bug: 368461853
Flag: EXEMPT remove launched flag
Test: presubmit
Change-Id: I0c6dd3bd8eb368dd577c58c0d5ff12147487a1c5
parent 7ad12f9f

core/java/android/window/flags/windowing_frontend.aconfig

+0 −10
Original line number Diff line number Diff line
@@ -206,16 +206,6 @@ flag { 
  bug: "377689543"

}



flag {

  name: "filter_irrelevant_input_device_change"

  namespace: "windowing_frontend"

  description: "Recompute display configuration only for necessary input device changes"

  bug: "368461853"

  metadata {

    purpose: PURPOSE_BUGFIX

  }

}



flag {

  name: "respect_non_top_visible_fixed_orientation"

  namespace: "windowing_frontend"

services/core/java/com/android/server/wm/InputManagerCallback.java

+1 −2
Original line number Diff line number Diff line
@@ -128,8 +128,7 @@ final class InputManagerCallback implements InputManagerService.WindowManagerCal 
    @Override

    public void notifyConfigurationChanged() {

        Trace.traceBegin(TRACE_TAG_WINDOW_MANAGER, "notifyConfigurationChanged");

        final boolean changed = !com.android.window.flags.Flags.filterIrrelevantInputDeviceChange()

                || updateLastInputConfigurationSources();

        final boolean changed = updateLastInputConfigurationSources();



        // Even if the input devices are not changed, there could be other pending changes

        // during booting. It's fine to apply earlier.

services/tests/wmtests/src/com/android/server/wm/WindowManagerServiceTests.java

+0 −1
Original line number Diff line number Diff line
@@ -1275,7 +1275,6 @@ public class WindowManagerServiceTests extends WindowTestsBase { 


    @Test

    public void testInputDeviceNotifyConfigurationChanged() {

        mSetFlagsRule.enableFlags(Flags.FLAG_FILTER_IRRELEVANT_INPUT_DEVICE_CHANGE);

        spyOn(mDisplayContent);

        doReturn(false).when(mDisplayContent).sendNewConfiguration();

        final InputDevice deviceA = mock(InputDevice.class);