Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fab92892 authored by Patrick Baumann's avatar Patrick Baumann Committed by android-build-team Robot
Browse files

Use KNOWN_PACKAGES when shared lib consumers 

This change ensures we find ALL known packages that could be consuming a
shared library, not only currently installed ones. Without this check,
the system may get into a state in which we have currently uninstalled
but on-device apps that depend on a shared library that does not exist
on device.

This change also leaves static shared library packages on device even if
it's not installed for any of the remaining users as it could still be
used, but marked uninstalled for users in which it is consumed.

Bug: 141413692
Bug: 142083996
Test: Manual; attempt to remove shared lib after marking its consumer uninstalled.
Test: atest StaticSharedLibsHostTests
Change-Id: Id4e37c3e4d3ea3ad5fddae5d2c7305e56f50eeea
(cherry picked from commit 34b504c3)
parent 18ed45f8

services/core/java/com/android/server/pm/PackageManagerService.java

+4 −3
Original line number Diff line number Diff line
@@ -18626,7 +18626,7 @@ public class PackageManagerService extends IPackageManager.Stub 
                            continue;

                        }

                        List<VersionedPackage> libClientPackages = getPackagesUsingSharedLibraryLPr(

                                libraryInfo, 0, currUserId);

                                libraryInfo, MATCH_KNOWN_PACKAGES, currUserId);

                        if (!ArrayUtils.isEmpty(libClientPackages)) {

                            Slog.w(TAG, "Not removing package " + pkg.manifestPackageName

                                    + " hosting lib " + libraryInfo.getName() + " version "
@@ -23652,8 +23652,9 @@ public class PackageManagerService extends IPackageManager.Stub 
                continue;

            }

            final String packageName = ps.pkg.packageName;

            // Skip over if system app

            if ((ps.pkgFlags & ApplicationInfo.FLAG_SYSTEM) != 0) {

            // Skip over if system app or static shared library

            if ((ps.pkgFlags & ApplicationInfo.FLAG_SYSTEM) != 0

                    || !TextUtils.isEmpty(ps.pkg.staticSharedLibName)) {

                continue;

            }

            if (DEBUG_CLEAN_APKS) {