Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa5b1695 authored by Michał Brzeziński's avatar Michał Brzeziński Committed by Automerger Merge Worker
Browse files

Merge "Improving comment inside expandWithQs for special split shade case"... 

Merge "Improving comment inside expandWithQs for special split shade case" into tm-dev am: 7144969d

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18281170



Change-Id: Icfb736cb8201976ad0b99aa7424067ef8d52c446
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents fb6accb1 7144969d

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java

+5 −3
Original line number Diff line number Diff line
@@ -1693,9 +1693,11 @@ public class NotificationPanelViewController extends PanelViewController { 
        if (mShouldUseSplitNotificationShade && isOnKeyguard()) {

            // It's a special case as this method is likely to not be initiated by finger movement

            // but rather called from adb shell or accessibility service.

            // In the future method below could be used for non-split shade as well but currently

            // motion in that case looks worse than using flingSettings.

            // TODO: make below function transitioning smoothly also in portrait with empty target

            // We're using LockscreenShadeTransitionController because on lockscreen that's the

            // source of truth for all shade motion. Not using it would make part of state to be

            // outdated and will cause bugs. Ideally we'd use this controller also for non-split

            // case but currently motion in portrait looks worse than when using flingSettings.

            // TODO: make below function transitioning smoothly also in portrait with null target

            mLockscreenShadeTransitionController.goToLockedShade(

                    /* expandedView= */null, /* needsQSAnimation= */false);

        } else if (isFullyCollapsed()) {