Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa2983da authored by Marcello Galhardo's avatar Marcello Galhardo
Browse files

Add Kotlin-friendly SingleActivityFactory class 

Test: atest ControlsEditingActivityTest
Test: atest ControlsFavoritingActivityTest
Test: atest ControlsProviderSelectorActivityTest
Test: atest ControlsRequestDialogTest
Test: atest ControlsActivityTest
Test: atest LaunchNotesRoleSettingsTrampolineActivityTest
Test: atest LaunchNoteTaskActivityTest
Test: atest UsbPermissionActivityTest
Flag: not needed
Fixes: b/289811651
Change-Id: I2395a11df6bf832239fd4db627f1a97796f2920e
parent 41b1f988

packages/SystemUI/tests/src/com/android/systemui/controls/management/ControlsEditingActivityTest.kt

+13 −18
Original line number Diff line number Diff line
@@ -11,9 +11,9 @@ import android.window.OnBackInvokedCallback 
import android.window.OnBackInvokedDispatcher

import androidx.test.filters.SmallTest

import androidx.test.rule.ActivityTestRule

import androidx.test.runner.intercepting.SingleActivityFactory

import com.android.systemui.R

import com.android.systemui.SysuiTestCase

import com.android.systemui.activity.SingleActivityFactory

import com.android.systemui.controls.CustomIconCache

import com.android.systemui.controls.controller.ControlsControllerImpl

import com.android.systemui.flags.FakeFeatureFlags
@@ -63,12 +63,8 @@ class ControlsEditingActivityTest : SysuiTestCase() { 
    @JvmField

    var activityRule =

        ActivityTestRule(

            object :

                SingleActivityFactory<TestableControlsEditingActivity>(

                    TestableControlsEditingActivity::class.java

                ) {

                override fun create(intent: Intent?): TestableControlsEditingActivity {

                    return TestableControlsEditingActivity(

            /* activityFactory= */ SingleActivityFactory {

                TestableControlsEditingActivity(

                    featureFlags,

                    uiExecutor,

                    controller,
@@ -77,10 +73,9 @@ class ControlsEditingActivityTest : SysuiTestCase() { 
                    mockDispatcher,

                    latch

                )

                }

            },

            false,

            false

            /* initialTouchMode= */ false,

            /* launchActivity= */ false,

        )



    @Before

packages/SystemUI/tests/src/com/android/systemui/controls/management/ControlsFavoritingActivityTest.kt

+13 −18
Original line number Diff line number Diff line
@@ -13,9 +13,9 @@ import android.window.OnBackInvokedDispatcher 
import androidx.test.filters.FlakyTest

import androidx.test.filters.SmallTest

import androidx.test.rule.ActivityTestRule

import androidx.test.runner.intercepting.SingleActivityFactory

import com.android.systemui.R

import com.android.systemui.SysuiTestCase

import com.android.systemui.activity.SingleActivityFactory

import com.android.systemui.controls.ControlStatus

import com.android.systemui.controls.ControlsServiceInfo

import com.android.systemui.controls.controller.ControlsController
@@ -91,12 +91,8 @@ class ControlsFavoritingActivityTest : SysuiTestCase() { 
    @JvmField

    var activityRule =

        ActivityTestRule(

            object :

                SingleActivityFactory<TestableControlsFavoritingActivity>(

                    TestableControlsFavoritingActivity::class.java

                ) {

                override fun create(intent: Intent?): TestableControlsFavoritingActivity {

                    return TestableControlsFavoritingActivity(

            /* activityFactory= */ SingleActivityFactory {

                TestableControlsFavoritingActivity(

                    featureFlags,

                    executor,

                    controller,
@@ -105,10 +101,9 @@ class ControlsFavoritingActivityTest : SysuiTestCase() { 
                    mockDispatcher,

                    latch

                )

                }

            },

            false,

            false

            /* initialTouchMode= */ false,

            /* launchActivity= */ false,

        )



    @Before

packages/SystemUI/tests/src/com/android/systemui/controls/management/ControlsProviderSelectorActivityTest.kt

+15 −20
Original line number Diff line number Diff line
@@ -29,8 +29,8 @@ import android.window.OnBackInvokedCallback 
import android.window.OnBackInvokedDispatcher

import androidx.test.filters.SmallTest

import androidx.test.rule.ActivityTestRule

import androidx.test.runner.intercepting.SingleActivityFactory

import com.android.systemui.SysuiTestCase

import com.android.systemui.activity.SingleActivityFactory

import com.android.systemui.controls.ControlsServiceInfo

import com.android.systemui.controls.controller.ControlsController

import com.android.systemui.controls.panels.AuthorizedPanelsRepository
@@ -91,12 +91,8 @@ class ControlsProviderSelectorActivityTest : SysuiTestCase() { 
    @JvmField

    var activityRule =

        ActivityTestRule(

            object :

                SingleActivityFactory<TestableControlsProviderSelectorActivity>(

                    TestableControlsProviderSelectorActivity::class.java

                ) {

                override fun create(intent: Intent?): TestableControlsProviderSelectorActivity {

                    return TestableControlsProviderSelectorActivity(

            /* activityFactory= */ SingleActivityFactory {

                TestableControlsProviderSelectorActivity(

                    executor,

                    backExecutor,

                    listingController,
@@ -107,10 +103,9 @@ class ControlsProviderSelectorActivityTest : SysuiTestCase() { 
                    mockDispatcher,

                    latch

                )

                }

            },

            false,

            false

            /* initialTouchMode= */ false,

            /* launchActivity= */ false,

        )



    @Before

packages/SystemUI/tests/src/com/android/systemui/controls/management/ControlsRequestDialogTest.kt

+13 −14
Original line number Diff line number Diff line
@@ -30,8 +30,8 @@ import android.testing.TestableLooper 
import androidx.lifecycle.Lifecycle

import androidx.test.filters.MediumTest

import androidx.test.rule.ActivityTestRule

import androidx.test.runner.intercepting.SingleActivityFactory

import com.android.systemui.SysuiTestCase

import com.android.systemui.activity.SingleActivityFactory

import com.android.systemui.controls.controller.ControlInfo

import com.android.systemui.controls.controller.ControlsController

import com.android.systemui.settings.UserTracker
@@ -81,19 +81,18 @@ class ControlsRequestDialogTest : SysuiTestCase() { 


    @Rule

    @JvmField

    var activityRule = ActivityTestRule<TestControlsRequestDialog>(

            object : SingleActivityFactory<TestControlsRequestDialog>(

                    TestControlsRequestDialog::class.java

            ) {

                    override fun create(intent: Intent?): TestControlsRequestDialog {

                        return TestControlsRequestDialog(

    var activityRule = ActivityTestRule(

        /* activityFactory= */ SingleActivityFactory {

            TestControlsRequestDialog(

                    mainExecutor,

                    controller,

                    userTracker,

                    listingController

            )

                    }

            }, false, false)

        },

        /* initialTouchMode= */ false,

        /* launchActivity= */ false,

    )



    private lateinit var control: Control

packages/SystemUI/tests/src/com/android/systemui/controls/ui/ControlsActivityTest.kt

+12 −17
Original line number Diff line number Diff line
@@ -23,8 +23,8 @@ import android.testing.AndroidTestingRunner 
import android.testing.TestableLooper

import androidx.test.filters.SmallTest

import androidx.test.rule.ActivityTestRule

import androidx.test.runner.intercepting.SingleActivityFactory

import com.android.systemui.SysuiTestCase

import com.android.systemui.activity.SingleActivityFactory

import com.android.systemui.broadcast.BroadcastDispatcher

import com.android.systemui.controls.settings.ControlsSettingsDialogManager

import com.android.systemui.flags.FeatureFlags
@@ -53,12 +53,8 @@ class ControlsActivityTest : SysuiTestCase() { 
    @JvmField

    var activityRule =

        ActivityTestRule(

            object :

                SingleActivityFactory<TestableControlsActivity>(

                    TestableControlsActivity::class.java

                ) {

                override fun create(intent: Intent?): TestableControlsActivity {

                    return TestableControlsActivity(

            /* activityFactory= */ SingleActivityFactory {

                TestableControlsActivity(

                    uiController,

                    broadcastDispatcher,

                    dreamManager,
@@ -66,10 +62,9 @@ class ControlsActivityTest : SysuiTestCase() { 
                    controlsSettingsDialogManager,

                    keyguardStateController,

                )

                }

            },

            false,

            false

            /* initialTouchMode= */ false,

            /* launchActivity= */ false,

        )



    @Before