Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f97fbd3b authored by Matt Gilbride's avatar Matt Gilbride
Browse files

baseline services.impl, update services.core.unboosted 

Update the lint baseline for `services.core.unboosted`, and apply the
same to `services.impl` where most sources are compiled as well.

Bug: 264451752
Test: TH
Flag: NONE lint baseline only
Change-Id: Ic1ca7c20fdc13a15b2ae4ff05d2e0887638e4dad
parent 01d38936

services/Android.bp

+4 −0
Original line number Diff line number Diff line
@@ -363,6 +363,10 @@ java_library { 
        ":__subpackages__",

        "//frameworks/opt:__subpackages__",

    ],



    lint: {

        baseline_filename: "lint-baseline.xml",

    },

}



// merge all required services into one final installable jar

services/core/lint-baseline.xml

+16 −0
Original line number Diff line number Diff line
@@ -849,4 +849,20 @@ 
            column="9"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        severity="Error"

        message="IMediaProjectionManager permission check should be converted to @EnforcePermission annotation"

        category="Security"

        priority="5"

        summary="Manual permission check can be @EnforcePermission annotation"

        explanation="Whenever possible, method implementations of AIDL interfaces should use the @EnforcePermission&#xA;annotation to declare the permissions to be enforced.  The verification code is then&#xA;generated by the AIDL compiler, which also takes care of annotating the generated java&#xA;code.&#xA;&#xA;This reduces the risk of bugs around these permission checks (that often become vulnerabilities).&#xA;It also enables easier auditing and review.&#xA;&#xA;Please migrate to an @EnforcePermission annotation. (See: go/aidl-enforce-howto)"

        errorLine1="            if (mContext.checkCallingOrSelfPermission(MANAGE_MEDIA_PROJECTION)"

        errorLine2="            ^">

        <location

            file="frameworks/base/services/core/java/com/android/server/media/projection/MediaProjectionManagerService.java"

            line="807"

            column="13"/>

    </issue>



</issues>