Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f975548f authored by Michal Brzezinski's avatar Michal Brzezinski Committed by Michał Brzeziński
Browse files

Follow-up fixes to ag/21609953 

- Window title seems to matter only for layout inspectors, all other windows in sysui also have non-resource name. Also checked that Talkback doesn't announce this title
- Changed getColor(resource) to getColor(resource, theme) and passed theme (null would also work, it doesn't really matter for now)

Bug: 268650355
Test: backlight dialog still works
Change-Id: Id6660f5dcc7f9deea10033583e2b760d2a55bf3a
parent 5b9dc212

packages/SystemUI/src/com/android/systemui/keyboard/backlight/ui/view/KeyboardBacklightDialog.kt

+3 −4
Original line number Diff line number Diff line
@@ -90,9 +90,9 @@ class KeyboardBacklightDialog( 


    private fun updateResources() {

        context.resources.apply {

            filledRectangleColor = getColor(R.color.backlight_indicator_step_filled)

            emptyRectangleColor = getColor(R.color.backlight_indicator_step_empty)

            backgroundColor = getColor(R.color.backlight_indicator_background)

            filledRectangleColor = getColor(R.color.backlight_indicator_step_filled, context.theme)

            emptyRectangleColor = getColor(R.color.backlight_indicator_step_empty, context.theme)

            backgroundColor = getColor(R.color.backlight_indicator_background, context.theme)

            rootProperties =

                RootProperties(

                    cornerRadius =
@@ -224,7 +224,6 @@ class KeyboardBacklightDialog( 


    private fun setWindowTitle() {

        val attrs = window.attributes

        // TODO(b/271796169): check if title needs to be a translatable resource.

        attrs.title = "KeyboardBacklightDialog"

        attrs?.y = dialogBottomMargin

        window.attributes = attrs