Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8e813e6 authored by Jeff DeCew's avatar Jeff DeCew Committed by Android (Google) Code Review
Browse files

Merge "[RESTRICT AUTOMERGE] Add BubbleMetadata detection to block FSI" into tm-dev

parents b4e180f3 e65f0c96

packages/SystemUI/src/com/android/systemui/statusbar/notification/interruption/NotificationInterruptStateProviderImpl.java

+12 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.systemui.statusbar.notification.interruption; 


import static com.android.systemui.statusbar.StatusBarState.SHADE;



import android.app.Notification;

import android.app.NotificationManager;

import android.content.ContentResolver;

import android.database.ContentObserver;
@@ -204,6 +205,17 @@ public class NotificationInterruptStateProviderImpl implements NotificationInter 
            return false;

        }



        // If the notification has suppressive BubbleMetadata, block FSI and warn.

        Notification.BubbleMetadata bubbleMetadata = sbn.getNotification().getBubbleMetadata();

        if (bubbleMetadata != null && bubbleMetadata.isNotificationSuppressed()) {

            // b/274759612: Detect and report an event when a notification has both an FSI and a

            // suppressive BubbleMetadata, and now correctly block the FSI from firing.

            final int uid = entry.getSbn().getUid();

            android.util.EventLog.writeEvent(0x534e4554, "274759612", uid, "bubbleMetadata");

            mLogger.logNoFullscreenWarning(entry, "BubbleMetadata may prevent HUN");

            return false;

        }



        // If the screen is off, then launch the FullScreenIntent

        if (!mPowerManager.isInteractive()) {

            mLogger.logFullscreen(entry, "Device is not interactive");

packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/interruption/NotificationInterruptStateProviderImplTest.java

+21 −0
Original line number Diff line number Diff line
@@ -468,9 +468,30 @@ public class NotificationInterruptStateProviderImplTest extends SysuiTestCase { 
        verify(mLogger, never()).logFullscreen(any(), any());

    }





    @Test

    public void testShouldNotFullScreen_isSuppressedByBubbleMetadata() throws RemoteException {

        NotificationEntry entry = createFsiNotification(IMPORTANCE_HIGH, /* silenced */ false);

        Notification.BubbleMetadata bubbleMetadata = new Notification.BubbleMetadata.Builder("foo")

                .setSuppressNotification(true).build();

        entry.getSbn().getNotification().setBubbleMetadata(bubbleMetadata);

        when(mPowerManager.isInteractive()).thenReturn(false);

        when(mDreamManager.isDreaming()).thenReturn(true);

        when(mStatusBarStateController.getState()).thenReturn(KEYGUARD);



        assertThat(mNotifInterruptionStateProvider.shouldLaunchFullScreenIntentWhenAdded(entry))

                .isFalse();

        verify(mLogger, never()).logNoFullscreen(any(), any());

        verify(mLogger).logNoFullscreenWarning(entry, "GroupAlertBehavior will prevent HUN");

        verify(mLogger, never()).logFullscreen(any(), any());

    }



    @Test

    public void testShouldFullScreen_notInteractive() throws RemoteException {

        NotificationEntry entry = createFsiNotification(IMPORTANCE_HIGH, /* silenced */ false);

        Notification.BubbleMetadata bubbleMetadata = new Notification.BubbleMetadata.Builder("foo")

                .setSuppressNotification(false).build();

        entry.getSbn().getNotification().setBubbleMetadata(bubbleMetadata);

        when(mPowerManager.isInteractive()).thenReturn(false);

        when(mDreamManager.isDreaming()).thenReturn(false);

        when(mStatusBarStateController.getState()).thenReturn(SHADE);