Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f89e732d authored by Colin Cross's avatar Colin Cross
Browse files

Use errorprone.extra_check_modules for error prone checks 

Using plugins for error prone checks causes them to be moved from
javac to kotlin, breaking the errorprone javac run which can no longer
find the checks requested in the errorprone javacflags.  Move the
checks to errorprone.extra_check_modules that will always apply to
the errorprone javac run.

Fixes: 190418963
Test: m RUN_ERROR_PRONE=true StatementService
Change-Id: I342d9129cf2ca769041c1be1c82498e27db45903
parent 2903ad55

packages/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -24,8 +24,8 @@ package { 


java_defaults {

    name: "platform_app_defaults",

    plugins: ["error_prone_android_framework"],

    errorprone: {

        extra_check_modules: ["error_prone_android_framework"],

        javacflags: [

            // We're less worried about performance in app code

            "-Xep:AndroidFrameworkEfficientCollections:OFF",

packages/StatementService/Android.bp

+1 −2
Original line number Diff line number Diff line
@@ -22,8 +22,7 @@ package { 


android_app {

    name: "StatementService",

    // Removed because Errorprone doesn't work with Kotlin, can fix up in the future

    // defaults: ["platform_app_defaults"],

    defaults: ["platform_app_defaults"],

    srcs: [

        "src/**/*.java",

        "src/**/*.kt",