Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f89a860c authored by Selim Cinek's avatar Selim Cinek
Browse files

Enable a user to collapse QS directly from the home handle 

Previously, this was taken by qs during collapsing.
We now allow for direct collapse when starting on the handle.

Fixes: 189427159
Test: expand qs, swipe from home handle, observe collapsing
Change-Id: Ied55a14027f003ef4fe2f6f2d4f3cf3c40070b63
parent 0e139daa

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java

+20 −3
Original line number Diff line number Diff line
@@ -101,6 +101,7 @@ import com.android.systemui.fragments.FragmentService; 
import com.android.systemui.media.KeyguardMediaController;

import com.android.systemui.media.MediaDataManager;

import com.android.systemui.media.MediaHierarchyManager;

import com.android.systemui.navigationbar.NavigationModeController;

import com.android.systemui.plugins.FalsingManager;

import com.android.systemui.plugins.FalsingManager.FalsingTapListener;

import com.android.systemui.plugins.qs.DetailAdapter;
@@ -108,6 +109,7 @@ import com.android.systemui.plugins.qs.QS; 
import com.android.systemui.plugins.statusbar.StatusBarStateController;

import com.android.systemui.plugins.statusbar.StatusBarStateController.StateListener;

import com.android.systemui.qs.QSDetailDisplayer;

import com.android.systemui.shared.system.QuickStepContract;

import com.android.systemui.statusbar.CommandQueue;

import com.android.systemui.statusbar.FeatureFlags;

import com.android.systemui.statusbar.GestureRecorder;
@@ -581,6 +583,11 @@ public class NotificationPanelViewController extends PanelViewController { 
     * The alpha of the views which only show on the keyguard but not in shade / shade locked

     */

    private float mKeyguardOnlyContentAlpha = 1.0f;



    /**

     * Are we currently in gesture navigation

     */

    private boolean mIsGestureNavigation;

    private int mOldLayoutDirection;

    private NotificationShelfController mNotificationShelfController;

    private int mScrimCornerRadius;
@@ -669,6 +676,7 @@ public class NotificationPanelViewController extends PanelViewController { 
            KeyguardMediaController keyguardMediaController,

            PrivacyDotViewController privacyDotViewController,

            TapAgainViewController tapAgainViewController,

            NavigationModeController navigationModeController,

            FragmentService fragmentService,

            QuickAccessWalletController quickAccessWalletController,

            @Main Executor uiExecutor,
@@ -769,6 +777,9 @@ public class NotificationPanelViewController extends PanelViewController { 
        mAuthController = authController;

        mLockIconViewController = lockIconViewController;

        mUnlockedScreenOffAnimationController = unlockedScreenOffAnimationController;

        int currentMode = navigationModeController.addListener(

                mode -> mIsGestureNavigation = QuickStepContract.isGesturalMode(mode));

        mIsGestureNavigation = QuickStepContract.isGesturalMode(currentMode);



        mView.setBackgroundColor(Color.TRANSPARENT);

        OnAttachStateChangeListener onAttachStateChangeListener = new OnAttachStateChangeListener();
@@ -1808,9 +1819,15 @@ public class NotificationPanelViewController extends PanelViewController { 
    }



    private boolean isInQsArea(float x, float y) {

        return (x >= mQsFrame.getX() && x <= mQsFrame.getX() + mQsFrame.getWidth()) && (

                y <= mNotificationStackScrollLayoutController.getBottomMostNotificationBottom()

                        || y <= mQs.getView().getY() + mQs.getView().getHeight());

        if (x < mQsFrame.getX() || x > mQsFrame.getX() + mQsFrame.getWidth()) {

            return false;

        }

        // Let's reject anything at the very bottom around the home handle in gesture nav

        if (mIsGestureNavigation && y > mView.getHeight() - mNavigationBarBottomHeight) {

            return false;

        }

        return y <= mNotificationStackScrollLayoutController.getBottomMostNotificationBottom()

                        || y <= mQs.getView().getY() + mQs.getView().getHeight();

    }



    private boolean isOpenQsEvent(MotionEvent event) {

packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/NotificationPanelViewTest.java

+4 −0
Original line number Diff line number Diff line
@@ -82,6 +82,7 @@ import com.android.systemui.fragments.FragmentService; 
import com.android.systemui.media.KeyguardMediaController;

import com.android.systemui.media.MediaDataManager;

import com.android.systemui.media.MediaHierarchyManager;

import com.android.systemui.navigationbar.NavigationModeController;

import com.android.systemui.plugins.FalsingManager;

import com.android.systemui.plugins.qs.QS;

import com.android.systemui.qs.QSDetailDisplayer;
@@ -261,6 +262,8 @@ public class NotificationPanelViewTest extends SysuiTestCase { 
    @Mock

    private PrivacyDotViewController mPrivacyDotViewController;

    @Mock

    private NavigationModeController mNavigationModeController;

    @Mock

    private SecureSettings mSecureSettings;

    @Mock

    private TapAgainViewController mTapAgainViewController;
@@ -391,6 +394,7 @@ public class NotificationPanelViewTest extends SysuiTestCase { 
                mKeyguardMediaController,

                mPrivacyDotViewController,

                mTapAgainViewController,

                mNavigationModeController,

                mFragmentService,

                mQuickAccessWalletController,

                new FakeExecutor(new FakeSystemClock()),