Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f81a67fa authored by Winson Chung's avatar Winson Chung
Browse files

Fix noisy pip logs 

- Whenever the shelf height changes, we still call into movement bounds
  changed which triggers menu resize even if not in pip

Bug: 183756396
Test: Open/close all apps, ensure no pip logs when not in pip
Change-Id: Ia27be382316f44bb161a0f3beecd6859813d0a66
parent f9060291

libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTaskOrganizer.java

+3 −0
Original line number Diff line number Diff line
@@ -1011,6 +1011,9 @@ public class PipTaskOrganizer implements ShellTaskOrganizer.TaskListener, 


    /** Moves the PiP menu to the destination bounds. */

    public void finishResizeForMenu(Rect destinationBounds) {

        if (!isInPip()) {

            return;

        }

        mPipMenuController.movePipMenu(null, null, destinationBounds);

        mPipMenuController.updateMenuBounds(destinationBounds);

    }

libs/WindowManager/Shell/src/com/android/wm/shell/pip/phone/PhonePipMenuController.java

+1 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ import java.util.List; 
 */

public class PhonePipMenuController implements PipMenuController {



    private static final String TAG = "PipMenuActController";

    private static final String TAG = "PhonePipMenuController";

    private static final boolean DEBUG = false;



    public static final int MENU_STATE_NONE = 0;