Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f801084e authored by Dave Mankoff's avatar Dave Mankoff
Browse files

Add null check to AsyncSensorManager.requestTriggerSensorImpl. 

I can't find us passing a null sensor in anywhere, but the stacktrace
in the bug shows otherwise. Unfortunately, because of the async nature
of this class, the caller is not available. With this change, we will
at least get a usefull stacktrace.

Bug: 142410226
Test: manual
Change-Id: I29547965e6e302f0b873f51e11da2010d2ccaa02
parent 0fd72921

packages/SystemUI/src/com/android/systemui/util/sensors/AsyncSensorManager.java

+6 −0
Original line number Original line Diff line number Diff line
@@ -139,6 +139,12 @@ public class AsyncSensorManager extends SensorManager 




    @Override

    @Override

    protected boolean requestTriggerSensorImpl(TriggerEventListener listener, Sensor sensor) {

    protected boolean requestTriggerSensorImpl(TriggerEventListener listener, Sensor sensor) {

        if (listener == null) {

            throw new IllegalArgumentException("listener cannot be null");

        }

        if (sensor == null) {

            throw new IllegalArgumentException("sensor cannot be null");

        }

        mHandler.post(() -> {

        mHandler.post(() -> {

            if (!mInner.requestTriggerSensor(listener, sensor)) {

            if (!mInner.requestTriggerSensor(listener, sensor)) {

                Log.e(TAG, "Requesting " + listener + " for " + sensor + " failed.");

                Log.e(TAG, "Requesting " + listener + " for " + sensor + " failed.");