Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7a00887 authored by Hongwei Wang's avatar Hongwei Wang Committed by Automerger Merge Worker
Browse files

Merge "Validate content overlay before removal" into tm-dev am: eb700c00 am: 8cd0c550 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18656364



Change-Id: Iae561b4414ce2332b84004483ebabbb6914d6cb1
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 72a27f37 8cd0c550

libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTaskOrganizer.java

+5 −0
Original line number Diff line number Diff line
@@ -1604,6 +1604,11 @@ public class PipTaskOrganizer implements ShellTaskOrganizer.TaskListener, 
            // Avoid double removal, which is fatal.

            return;

        }

        if (surface == null || !surface.isValid()) {

            ProtoLog.w(ShellProtoLogGroup.WM_SHELL_PICTURE_IN_PICTURE,

                    "%s: trying to remove invalid content overlay (%s)", TAG, surface);

            return;

        }

        final SurfaceControl.Transaction tx = mSurfaceControlTransactionFactory.getTransaction();

        tx.remove(surface);

        tx.apply();