Merge "Do not show UMO resumption state in the hub" into main (f7476a14) · Commits · e / os / android_frameworks_base

packages/SystemUI/multivalentTests/src/com/android/systemui/communal/data/repository/CommunalMediaRepositoryImplTest.kt

+8 −8

Original line number	Diff line number	Diff line
		@@ -72,7 +72,7 @@ class CommunalMediaRepositoryImplTest : SysuiTestCase() {
		testScope.runTest {
		val mediaModel = collectLastValue(underTest.mediaModel)
		runCurrent()
		assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isFalse()
		assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isFalse()
		}

		@Test
		@@ -84,16 +84,16 @@ class CommunalMediaRepositoryImplTest : SysuiTestCase() {
		// Initial value is false.
		val mediaModel = collectLastValue(underTest.mediaModel)
		runCurrent()
		assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isFalse()
		assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isFalse()

		// Change to media available and notify the listener.
		whenever(mediaDataManager.hasAnyMediaOrRecommendation()).thenReturn(true)
		whenever(mediaDataManager.hasActiveMediaOrRecommendation()).thenReturn(true)
		whenever(mediaData.createdTimestampMillis).thenReturn(1234L)
		mediaDataListenerCaptor.value.onMediaDataLoaded("key", null, mediaData)
		runCurrent()

		// Media active now returns true.
		assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isTrue()
		assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isTrue()
		assertThat(mediaModel()?.createdTimestampMillis).isEqualTo(1234L)
		}

		@@ -104,20 +104,20 @@ class CommunalMediaRepositoryImplTest : SysuiTestCase() {
		verify(mediaDataManager).addListener(mediaDataListenerCaptor.capture())

		// Change to media available and notify the listener.
		whenever(mediaDataManager.hasAnyMediaOrRecommendation()).thenReturn(true)
		whenever(mediaDataManager.hasActiveMediaOrRecommendation()).thenReturn(true)
		mediaDataListenerCaptor.value.onMediaDataLoaded("key", null, mediaData)
		runCurrent()

		// Media active now returns true.
		val mediaModel = collectLastValue(underTest.mediaModel)
		assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isTrue()
		assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isTrue()

		// Change to media unavailable and notify the listener.
		whenever(mediaDataManager.hasAnyMediaOrRecommendation()).thenReturn(false)
		whenever(mediaDataManager.hasActiveMediaOrRecommendation()).thenReturn(false)
		mediaDataListenerCaptor.value.onMediaDataRemoved("key")
		runCurrent()

		// Media active now returns false.
		assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isFalse()
		assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isFalse()
		}
		}

packages/SystemUI/src/com/android/systemui/communal/data/model/CommunalMediaModel.kt

+4 −4

Original line number	Diff line number	Diff line
		@@ -21,21 +21,21 @@ import com.android.systemui.log.table.TableRowLogger

		/** Data model of media on the communal hub. */
		data class CommunalMediaModel(
		val hasAnyMediaOrRecommendation: Boolean,
		val hasActiveMediaOrRecommendation: Boolean,
		val createdTimestampMillis: Long = 0L,
		) : Diffable<CommunalMediaModel> {
		companion object {
		val INACTIVE =
		CommunalMediaModel(
		hasAnyMediaOrRecommendation = false,
		hasActiveMediaOrRecommendation = false,
		)
		}

		override fun logDiffs(prevVal: CommunalMediaModel, row: TableRowLogger) {
		if (hasAnyMediaOrRecommendation != prevVal.hasAnyMediaOrRecommendation) {
		if (hasActiveMediaOrRecommendation != prevVal.hasActiveMediaOrRecommendation) {
		row.logChange(
		columnName = "isMediaActive",
		value = hasAnyMediaOrRecommendation,
		value = hasActiveMediaOrRecommendation,
		)
		}

packages/SystemUI/src/com/android/systemui/communal/data/repository/CommunalMediaRepository.kt

+2 −2

Original line number	Diff line number	Diff line
		@@ -73,10 +73,10 @@ constructor(
		)

		private fun updateMediaModel(data: MediaData? = null) {
		if (mediaDataManager.hasAnyMediaOrRecommendation()) {
		if (mediaDataManager.hasActiveMediaOrRecommendation()) {
		_mediaModel.value =
		CommunalMediaModel(
		hasAnyMediaOrRecommendation = true,
		hasActiveMediaOrRecommendation = true,
		createdTimestampMillis = data?.createdTimestampMillis ?: 0L,
		)
		} else {

packages/SystemUI/src/com/android/systemui/communal/domain/interactor/CommunalInteractor.kt

+1 −1

Original line number	Diff line number	Diff line
		@@ -318,7 +318,7 @@ constructor(
		)

		// Add UMO
		if (media.hasAnyMediaOrRecommendation) {
		if (media.hasActiveMediaOrRecommendation) {
		ongoingContent.add(
		CommunalContentModel.Umo(
		createdTimestampMillis = media.createdTimestampMillis,

packages/SystemUI/src/com/android/systemui/communal/ui/viewmodel/CommunalViewModel.kt

+1 −1

Original line number	Diff line number	Diff line
		@@ -87,7 +87,7 @@ constructor(
		with(mediaHost) {
		expansion = MediaHostState.EXPANDED
		expandedMatchesParentHeight = true
		showsOnlyActiveMedia = false
		showsOnlyActiveMedia = true
		falsingProtectionNeeded = false
		init(MediaHierarchyManager.LOCATION_COMMUNAL_HUB)
		}