Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f67ef873 authored by Jeff Sharkey's avatar Jeff Sharkey Committed by Jeff Sharkey
Browse files

Omit links for custom ErrorProne checkers. 

We don't have published docs describing these checkers, so avoid
attempting to auto-generate default links.

Bug: 195785607
Test: none
Change-Id: I8810a8eac6cc2b462d76abaec5242c440494e57e
parent 0ee662a0

errorprone/java/com/google/errorprone/bugpatterns/android/BinderIdentityChecker.java

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.google.errorprone.bugpatterns.android;



import static com.google.errorprone.BugPattern.LinkType.NONE;

import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;

import static com.google.errorprone.matchers.Matchers.contains;

import static com.google.errorprone.matchers.Matchers.methodInvocation;
@@ -52,6 +53,7 @@ import javax.lang.model.element.Modifier; 
@BugPattern(

    name = "AndroidFrameworkBinderIdentity",

    summary = "Verifies that Binder.clearCallingIdentity() is always restored",

    linkType = NONE,

    severity = WARNING)

public final class BinderIdentityChecker extends BugChecker implements MethodInvocationTreeMatcher {

    private static final Matcher<ExpressionTree> CLEAR_CALL = methodInvocation(staticMethod()

errorprone/java/com/google/errorprone/bugpatterns/android/BluetoothPermissionChecker.java

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.google.errorprone.bugpatterns.android;



import static com.google.errorprone.BugPattern.LinkType.NONE;

import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;

import static com.google.errorprone.bugpatterns.android.RequiresPermissionChecker.simpleNameMatches;

import static com.google.errorprone.matchers.Matchers.allOf;
@@ -60,6 +61,7 @@ import java.util.regex.Pattern; 
@BugPattern(

    name = "AndroidFrameworkBluetoothPermission",

    summary = "Verifies that all Bluetooth APIs have consistent permissions",

    linkType = NONE,

    severity = WARNING)

public final class BluetoothPermissionChecker extends BugChecker implements MethodTreeMatcher {

    private static final Matcher<MethodTree> BLUETOOTH_API = allOf(

errorprone/java/com/google/errorprone/bugpatterns/android/ClientSidePermissionCheckChecker.java

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.google.errorprone.bugpatterns.android;



import static com.google.errorprone.BugPattern.LinkType.NONE;

import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;

import static com.google.errorprone.matchers.Matchers.anyOf;

import static com.google.errorprone.matchers.Matchers.enclosingClass;
@@ -42,6 +43,7 @@ import com.sun.source.tree.Tree; 
@BugPattern(

        name = "AndroidFrameworkClientSidePermissionCheck",

        summary = "Verifies that permission checks aren't done in the app's process",

        linkType = NONE,

        severity = WARNING)

public final class ClientSidePermissionCheckChecker

        extends BugChecker implements MethodInvocationTreeMatcher {

errorprone/java/com/google/errorprone/bugpatterns/android/CompatChangeChecker.java

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.google.errorprone.bugpatterns.android;



import static com.google.errorprone.BugPattern.LinkType.NONE;

import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;

import static com.google.errorprone.bugpatterns.android.TargetSdkChecker.binaryTreeExact;

import static com.google.errorprone.matchers.Matchers.allOf;
@@ -51,6 +52,7 @@ import com.sun.source.tree.Tree.Kind; 
@BugPattern(

    name = "AndroidFrameworkCompatChange",

    summary = "Verifies that behavior changes use the modern compatibility framework",

    linkType = NONE,

    severity = WARNING)

public final class CompatChangeChecker extends BugChecker implements BinaryTreeMatcher {

    private static final Matcher<ExpressionTree> VERSION_CODE =

errorprone/java/com/google/errorprone/bugpatterns/android/ContextUserIdChecker.java

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.google.errorprone.bugpatterns.android;



import static com.google.errorprone.BugPattern.LinkType.NONE;

import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;

import static com.google.errorprone.bugpatterns.android.UidChecker.getFlavor;

import static com.google.errorprone.matchers.Matchers.anyOf;
@@ -54,6 +55,7 @@ import java.util.List; 
@BugPattern(

    name = "AndroidFrameworkContextUserId",

    summary = "Verifies that system_server calls use Context.getUserId()",

    linkType = NONE,

    severity = WARNING)

public final class ContextUserIdChecker extends BugChecker implements MethodInvocationTreeMatcher {

    private static final Matcher<Tree> INSIDE_MANAGER =