Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f66e930e authored by Brian Colonna's avatar Brian Colonna
Browse files

Passing useLiveliness flag to FUL in startUi call 

Because of changes in support of multi-user functionaity, the FUL
'eye blink' checkbox was no longer enabling liveliness detection.

It no longer makes sense to check the biometric flags (such as the
liveliness flag) inside of the Face Unlock service.  Instead, that
flag is now passed in from lockscreen via the aidl interface when
startUi is called.

Change-Id: I591cf1924fbb24da7d54b94ef29824e5197d3b20
parent 425c726a

core/java/com/android/internal/policy/IFaceLockInterface.aidl

+2 −1
Original line number Original line Diff line number Diff line
@@ -20,7 +20,8 @@ import com.android.internal.policy.IFaceLockCallback; 




/** {@hide} */

/** {@hide} */

interface IFaceLockInterface {

interface IFaceLockInterface {

    void startUi(IBinder containingWindowToken, int x, int y, int width, int height);

    void startUi(IBinder containingWindowToken, int x, int y, int width, int height,

            boolean useLiveliness);

    void stopUi();

    void stopUi();

    void registerCallback(IFaceLockCallback cb);

    void registerCallback(IFaceLockCallback cb);

    void unregisterCallback(IFaceLockCallback cb);

    void unregisterCallback(IFaceLockCallback cb);

policy/src/com/android/internal/policy/impl/FaceUnlock.java

+2 −1
Original line number Original line Diff line number Diff line
@@ -291,7 +291,8 @@ public class FaceUnlock implements Handler.Callback { 
                if (!mServiceRunning) {

                if (!mServiceRunning) {

                    if (DEBUG) Log.d(TAG, "Starting FaceLock");

                    if (DEBUG) Log.d(TAG, "Starting FaceLock");

                    try {

                    try {

                        mService.startUi(windowToken, x, y, w, h);

                        mService.startUi(windowToken, x, y, w, h,

                                mLockPatternUtils.isBiometricWeakLivelinessEnabled());

                    } catch (RemoteException e) {

                    } catch (RemoteException e) {

                        Log.e(TAG, "Caught exception starting FaceLock: " + e.toString());

                        Log.e(TAG, "Caught exception starting FaceLock: " + e.toString());

                        return;

                        return;