Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4f17442 authored by Kevin Jeon's avatar Kevin Jeon
Browse files

Annotate dump methods with @NeverCompile [1/5] 

This change annotates dump/debug methods in services.odex that are
larger than 10000 bytes with NeverCompile so that they will not be
compiled. This results in an overall ~1% decrease in the size of
services.odex.

Bug: 215417388
Test: Build and check that these methods are not called during boot or
      app startup.
Change-Id: I0b8d62c68a6a79c07f2a8a533bf69aee100f0877
parent ce48a19f

apex/jobscheduler/service/java/com/android/server/alarm/AlarmManagerService.java

+3 −0
Original line number Diff line number Diff line
@@ -148,6 +148,8 @@ import com.android.server.tare.EconomyManagerInternal; 
import com.android.server.usage.AppStandbyInternal;

import com.android.server.usage.AppStandbyInternal.AppIdleStateChangeListener;



import dalvik.annotation.optimization.NeverCompile;



import libcore.util.EmptyArray;



import java.io.FileDescriptor;
@@ -2851,6 +2853,7 @@ public class AlarmManagerService extends SystemService { 
                packageName, UserHandle.of(userId));

    }



    @NeverCompile // Avoid size overhead of debugging code.

    void dumpImpl(IndentingPrintWriter pw) {

        synchronized (mLock) {

            pw.println("Current Alarm Manager state:");

apex/jobscheduler/service/java/com/android/server/job/JobSchedulerService.java

+3 −0
Original line number Diff line number Diff line
@@ -125,6 +125,8 @@ import com.android.server.utils.quota.Categorizer; 
import com.android.server.utils.quota.Category;

import com.android.server.utils.quota.CountQuotaTracker;



import dalvik.annotation.optimization.NeverCompile;



import libcore.util.EmptyArray;



import java.io.FileDescriptor;
@@ -3714,6 +3716,7 @@ public class JobSchedulerService extends com.android.server.SystemService 
        });

    }



    @NeverCompile // Avoid size overhead of debugging code.

    void dumpInternal(final IndentingPrintWriter pw, int filterUid) {

        final int filterAppId = UserHandle.getAppId(filterUid);

        final long now = sSystemClock.millis();

apex/jobscheduler/service/java/com/android/server/job/controllers/JobStatus.java

+3 −0
Original line number Diff line number Diff line
@@ -55,6 +55,8 @@ import com.android.server.job.JobServerProtoEnums; 
import com.android.server.job.JobStatusDumpProto;

import com.android.server.job.JobStatusShortInfoProto;



import dalvik.annotation.optimization.NeverCompile;



import java.io.PrintWriter;

import java.util.ArrayList;

import java.util.Arrays;
@@ -1951,6 +1953,7 @@ public final class JobStatus { 
    }



    // Dumpsys infrastructure

    @NeverCompile // Avoid size overhead of debugging code.

    public void dump(IndentingPrintWriter pw,  boolean full, long nowElapsed) {

        UserHandle.formatUid(pw, callingUid);

        pw.print(" tag="); pw.println(tag);

apex/jobscheduler/service/java/com/android/server/job/controllers/QuotaController.java

+3 −0
Original line number Diff line number Diff line
@@ -74,6 +74,8 @@ import com.android.server.usage.AppStandbyInternal; 
import com.android.server.usage.AppStandbyInternal.AppIdleStateChangeListener;

import com.android.server.utils.AlarmQueue;



import dalvik.annotation.optimization.NeverCompile;



import java.util.ArrayList;

import java.util.List;

import java.util.function.Consumer;
@@ -3890,6 +3892,7 @@ public final class QuotaController extends StateController { 


    //////////////////////////// DATA DUMP //////////////////////////////



    @NeverCompile // Avoid size overhead of debugging code.

    @Override

    public void dumpControllerStateLocked(final IndentingPrintWriter pw,

            final Predicate<JobStatus> predicate) {

services/core/java/com/android/server/am/ActivityManagerConstants.java

+3 −0
Original line number Diff line number Diff line
@@ -44,6 +44,8 @@ import android.util.Slog; 


import com.android.internal.annotations.GuardedBy;



import dalvik.annotation.optimization.NeverCompile;



import java.io.PrintWriter;

import java.util.Arrays;

import java.util.List;
@@ -1389,6 +1391,7 @@ final class ActivityManagerConstants extends ContentObserver { 
        }

    }



    @NeverCompile // Avoid size overhead of debugging code.

    void dump(PrintWriter pw) {

        pw.println("ACTIVITY MANAGER SETTINGS (dumpsys activity settings) "

                + Settings.Global.ACTIVITY_MANAGER_CONSTANTS + ":");