Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4aae0b4 authored by David Liu's avatar David Liu
Browse files

Make sure subclasses calls super.onCreateView() if override in the subclass. 

If the subclass override the onCreateView but not call super, the AndroidX PreferenceFragmentCompat can not work properly (see b/392487897) which causes crash in setDivider().

Flag: EXEMPT small bug fix
Change-Id: Ibff90b6540a923e1ab0a4d6484f0bf1e8a72bfe9
parent f7af9754

packages/SettingsLib/SettingsTheme/src/com/android/settingslib/widget/SettingsBasePreferenceFragment.kt

+11 −0
Original line number Diff line number Diff line
@@ -17,7 +17,9 @@ 
package com.android.settingslib.widget



import android.os.Bundle

import android.view.LayoutInflater;

import android.view.View

import android.view.ViewGroup;

import androidx.annotation.CallSuper

import androidx.preference.PreferenceFragmentCompat

import androidx.preference.PreferenceScreen
@@ -26,6 +28,15 @@ import androidx.recyclerview.widget.RecyclerView 
/** Base class for Settings to use PreferenceFragmentCompat */

abstract class SettingsBasePreferenceFragment : PreferenceFragmentCompat() {



    @CallSuper

    override fun onCreateView(

        inflater: LayoutInflater,

        container: ViewGroup?,

        savedInstanceState: Bundle?

    ): View {

        return super.onCreateView(inflater, container, savedInstanceState)

    }



    @CallSuper

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {

        super.onViewCreated(view, savedInstanceState)