Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f256b0d4 authored by Felipe Leme's avatar Felipe Leme
Browse files

Don't register AdServices as dumpable anymore. 

AdServicesManager registers the adservices_manager service, but it
it was temporary not doing so on Android 13 disabled as it was breaking
some devices that explicitly allowlisted services (on selinux). but starting on Android 14, the adservices_manager is guaranteed (by CTS)
to be published, so this workaround is not needed anymore.

Bug: 282239822

Test: adb shell dumpsys system_server_dumper --list > /dev/null |grep AdServices && echo FAIL || echo SUCCESS
Test: adb shell service check adservices_manager | grep "not found" && echo FAIL || echo SUCCESS

Change-Id: Ib81dd850c12c461cbb2515d56cec0d992d366642
parent 418e4ba5

services/java/com/android/server/SystemServer.java

+1 −5
Original line number Diff line number Diff line
@@ -2719,11 +2719,7 @@ public final class SystemServer implements Dumpable { 


        // AdServicesManagerService (PP API service)

        t.traceBegin("StartAdServicesManagerService");

        SystemService adServices = mSystemServiceManager

                .startService(AD_SERVICES_MANAGER_SERVICE_CLASS);

        if (adServices instanceof Dumpable) {

            mDumper.addDumpable((Dumpable) adServices);

        }

        mSystemServiceManager.startService(AD_SERVICES_MANAGER_SERVICE_CLASS);

        t.traceEnd();



        // OnDevicePersonalizationSystemService