Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1e54c9a authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Modify SurfaceView to use SurfaceFlinger child surfaces."

parents e096df00 cd4aeef8
Loading
Loading
Loading
Loading
+22 −1
Original line number Diff line number Diff line
@@ -95,6 +95,11 @@ public class SurfaceControl {
            IBinder displayToken, int mode);
    private static native void nativeDeferTransactionUntil(long nativeObject,
            IBinder handle, long frame);
    private static native void nativeDeferTransactionUntilSurface(long nativeObject,
            long surfaceObject, long frame);
    private static native void nativeReparentChildren(long nativeObject,
            IBinder handle);
    private static native void nativeSeverChildren(long nativeObject);
    private static native void nativeSetOverrideScalingMode(long nativeObject,
            int scalingMode);
    private static native IBinder nativeGetHandle(long nativeObject);
@@ -418,8 +423,24 @@ public class SurfaceControl {
    }

    public void deferTransactionUntil(IBinder handle, long frame) {
        if (frame > 0) {
            nativeDeferTransactionUntil(mNativeObject, handle, frame);
        }
    }

    public void deferTransactionUntil(Surface barrier, long frame) {
        if (frame > 0) {
            nativeDeferTransactionUntilSurface(mNativeObject, barrier.mNativeObject, frame);
        }
    }

    public void reparentChildren(IBinder newParentHandle) {
        nativeReparentChildren(mNativeObject, newParentHandle);
    }

    public void detachChildren() {
        nativeSeverChildren(mNativeObject);
    }

    public void setOverrideScalingMode(int scalingMode) {
        checkNotReleased();
+5 −0
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ public final class SurfaceSession {
    private long mNativeClient; // SurfaceComposerClient*

    private static native long nativeCreate();
    private static native long nativeCreateScoped(long surfacePtr);
    private static native void nativeDestroy(long ptr);
    private static native void nativeKill(long ptr);

@@ -35,6 +36,10 @@ public final class SurfaceSession {
        mNativeClient = nativeCreate();
    }

    public SurfaceSession(Surface root) {
        mNativeClient = nativeCreateScoped(root.mNativeObject);
    }

    /* no user serviceable parts here ... */
    @Override
    protected void finalize() throws Throwable {
+184 −267

File changed.

Preview size limit exceeded, changes collapsed.

+9 −1
Original line number Diff line number Diff line
@@ -2632,6 +2632,14 @@ public final class ViewRootImpl implements ViewParent,
        }
    }

    private void onDrawFinished() {
        try {
            mWindowSession.finishDrawing(mWindow);
        } catch (RemoteException e) {
            // Have fun!
        }
    }

    private void performDraw() {
        if (mAttachInfo.mDisplayState == Display.STATE_OFF && !mReportNextDraw) {
            return;
@@ -2682,7 +2690,7 @@ public final class ViewRootImpl implements ViewParent,
            }

            if (mSurfaceHolder != null && mSurface.isValid()) {
                SurfaceCallbackHelper sch = new SurfaceCallbackHelper(mWindowSession, mWindow);
                SurfaceCallbackHelper sch = new SurfaceCallbackHelper(this::onDrawFinished);
                SurfaceHolder.Callback callbacks[] = mSurfaceHolder.getCallbacks();

                sch.dispatchSurfaceRedrawNeededAsync(mSurfaceHolder, callbacks);
+5 −16
Original line number Diff line number Diff line
@@ -17,14 +17,11 @@
package com.android.internal.view;

import android.os.RemoteException;
import android.view.IWindow;
import android.view.IWindowSession;
import android.view.Surface;
import android.view.SurfaceHolder;

public class SurfaceCallbackHelper {
    IWindowSession mSession;
    IWindow.Stub mWindow;
    Runnable mRunnable;

    int mFinishDrawingCollected = 0;
    int mFinishDrawingExpected = 0;
@@ -37,26 +34,18 @@ public class SurfaceCallbackHelper {
                    if (mFinishDrawingCollected < mFinishDrawingExpected) {
                        return;
                    }
                    try {
                        mSession.finishDrawing(mWindow);
                    } catch (RemoteException e) {
                    }
                    mRunnable.run();
                }
            }
    };

    public SurfaceCallbackHelper(IWindowSession session,
            IWindow.Stub window) {
        mSession = session;
        mWindow = window;
    public SurfaceCallbackHelper(Runnable callbacksCollected) {
        mRunnable = callbacksCollected;
    }

    public void dispatchSurfaceRedrawNeededAsync(SurfaceHolder holder, SurfaceHolder.Callback callbacks[]) {
        if (callbacks == null || callbacks.length == 0) {
            try {
                mSession.finishDrawing(mWindow);
            } catch (RemoteException e) {
            }
            mRunnable.run();
            return;
        }

Loading