Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1967c41 authored by Roshan Pius's avatar Roshan Pius
Browse files

Revert "Send empty LinkProperties when entering StoppedState." 

This reverts commit b3f9f4a3.

Reason for revert: Crash in WifiStateMachine (b/70394432)

Change-Id: I3a96c822eddcebcdd6621cee878b865171d094e8
parent b3f9f4a3

services/net/java/android/net/ip/IpClient.java

+2 −3
Original line number Diff line number Diff line
@@ -163,10 +163,10 @@ public class IpClient extends StateMachine { 
    // TODO: Find an lighter weight approach.

    private class LoggingCallbackWrapper extends Callback {

        private static final String PREFIX = "INVOKE ";

        private final Callback mCallback;

        private Callback mCallback;



        public LoggingCallbackWrapper(Callback callback) {

            mCallback = (callback != null) ? callback : new Callback();

            mCallback = callback;

        }



        private void log(String msg) {
@@ -1273,7 +1273,6 @@ public class IpClient extends StateMachine { 
            stopAllIP();



            resetLinkProperties();

            mCallback.onLinkPropertiesChange(new LinkProperties(mLinkProperties));

            if (mStartTimeMillis > 0) {

                recordMetric(IpManagerEvent.COMPLETE_LIFECYCLE);

                mStartTimeMillis = 0;

tests/net/java/android/net/ip/IpManagerTest.java

+0 −6
Original line number Diff line number Diff line
@@ -69,8 +69,6 @@ import java.util.Set; 


/**

 * Tests for IpManager.

 *

 * TODO: Rename to IpClientTest.

 */

@RunWith(AndroidJUnit4.class)

@SmallTest
@@ -113,10 +111,6 @@ public class IpManagerTest { 
        verify(mNMService, times(1)).registerObserver(arg.capture());

        mObserver = arg.getValue();

        reset(mNMService);

        final LinkProperties emptyLp = new LinkProperties();

        emptyLp.setInterfaceName(ifname);

        verify(mCb, timeout(100)).onLinkPropertiesChange(eq(emptyLp));

        reset(mCb);

        return ipm;

    }