Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f18e567b authored by Wilson Wu's avatar Wilson Wu
Browse files

Rename IInputMethodManager#reportPerceptible 

Rename this method to reportPerceptibleAsync
for readability, because it was already a truly
one-way method when it create.

Bug: 185281885
Test: atest CtsInputMethodTestCases
Change-Id: I9c72b980678f0310c79b293ea06f465e9ca1d760
parent f18be559

core/java/android/view/inputmethod/InputMethodManager.java

+1 −1
Original line number Diff line number Diff line
@@ -581,7 +581,7 @@ public final class InputMethodManager { 
     */

    public void reportPerceptible(IBinder windowToken, boolean perceptible) {

        try {

            mService.reportPerceptible(windowToken, perceptible);

            mService.reportPerceptibleAsync(windowToken, perceptible);

        } catch (RemoteException e) {

            throw e.rethrowFromSystemServer();

        }

core/java/com/android/internal/view/IInputMethodManager.aidl

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ interface IInputMethodManager { 
    oneway void reportActivityView(in IInputMethodClient parentClient, int childDisplayId,

            in float[] matrixValues, in IVoidResultCallback resultCallback);



    oneway void reportPerceptible(in IBinder windowToken, boolean perceptible);

    oneway void reportPerceptibleAsync(in IBinder windowToken, boolean perceptible);

    /** Remove the IME surface. Requires INTERNAL_SYSTEM_WINDOW permission. */

    oneway void removeImeSurface(in IVoidResultCallback resultCallback);

    /** Remove the IME surface. Requires passing the currently focused window. */

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -3177,7 +3177,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub 


    @BinderThread

    @Override

    public void reportPerceptible(IBinder windowToken, boolean perceptible) {

    public void reportPerceptibleAsync(IBinder windowToken, boolean perceptible) {

        Objects.requireNonNull(windowToken, "windowToken must not be null");

        int uid = Binder.getCallingUid();

        synchronized (mMethodMap) {

services/core/java/com/android/server/inputmethod/MultiClientInputMethodManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -1842,7 +1842,7 @@ public final class MultiClientInputMethodManagerService { 


        @BinderThread

        @Override

        public void reportPerceptible(IBinder windowClient, boolean perceptible) {

        public void reportPerceptibleAsync(IBinder windowClient, boolean perceptible) {

            reportNotSupported();

        }