Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1455b05 authored by Dave Mankoff's avatar Dave Mankoff
Browse files

Allow for more wiggle room (literally) in BrightlineFalsingManager. 

Bug: 138812628
Change-Id: I8590b2daff0337a395d333c07c2231cc10d236a3
Test: manual testing with different people to find better values.
parent d7a23cc7

packages/SystemUI/src/com/android/systemui/classifier/brightline/ZigZagClassifier.java

+2 −2
Original line number Diff line number Diff line
@@ -39,8 +39,8 @@ class ZigZagClassifier extends FalsingClassifier { 
    // most swipes will follow somewhat of a 'C' or 'S' shape, we allow more deviance along the

    // `SECONDARY` axis.

    private static final float MAX_X_PRIMARY_DEVIANCE = .05f;

    private static final float MAX_Y_PRIMARY_DEVIANCE = .05f;

    private static final float MAX_X_SECONDARY_DEVIANCE = .3f;

    private static final float MAX_Y_PRIMARY_DEVIANCE = .1f;

    private static final float MAX_X_SECONDARY_DEVIANCE = .6f;

    private static final float MAX_Y_SECONDARY_DEVIANCE = .3f;



    private final float mMaxXPrimaryDeviance;

packages/SystemUI/tests/src/com/android/systemui/classifier/brightline/ZigZagClassifierTest.java

+2 −2
Original line number Diff line number Diff line
@@ -133,8 +133,8 @@ public class ZigZagClassifierTest extends ClassifierTest { 
        // This test looks just like testPass_horizontalZigZagVerticalStraight but with

        // a shorter y range, making it look more crooked.

        appendMoveEvent(0, 0);

        appendMoveEvent(5, 10);

        appendMoveEvent(-5, 20);

        appendMoveEvent(6, 10);

        appendMoveEvent(-6, 20);

        assertThat(mClassifier.isFalseTouch(), is(true));

    }