Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit f11a9628 authored by Jared Duke's avatar Jared Duke
Browse files

Add flag-guarded disabling of default .art file madvise

The compressed .art app image file is read just once during process
startup. As such, there is little benefit to running a full madvise
before starting decompression, and in some cases this actually leads
to (slightly) worse latency.

Use a flag to control the default value for the ART runtime's
`-XMadviseWillNeedArtFileSize` configuration. Previously, this
was set via a makefile default to be UINT_MAX. This default is preserved
in the runtime, where the new aconfig flag disables this default
and turns off .art file madvise (unless the property is explicitly
configured for a particular device).

After ramping and validating performance impact, we may consider
deprecating and removing this ART runtime flag completely.

Flag: android.os.disable_madvise_artfile_default
Test: m
Test: adb shell aflags enable android.os.disable_madvise_artfile_default
   && adb shell setprop dalvik.vm.extra-opts -verbose:startup
   && adb logcat | grep Madvise
Bug: 382110550
Change-Id: I16170215da0d06a0fd110112fc17b03002939621
parent 9b20ff48
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment