Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0dd73ce authored by Zimuzo Ezeozue's avatar Zimuzo Ezeozue Committed by Automerger Merge Worker
Browse files

Merge "Skip tracing missing binder txn names" am: da1c78d1 am: c3355df5 

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2254719



Change-Id: I579ae708b1026b8128bfda9d8acad87965d01df2
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 13067850 c3355df5

core/java/android/os/Binder.java

+14 −1
Original line number Diff line number Diff line
@@ -1241,8 +1241,21 @@ public class Binder implements IBinder { 
        // If the call was {@link IBinder#FLAG_ONEWAY} then these exceptions

        // disappear into the ether.

        final boolean tagEnabled = Trace.isTagEnabled(Trace.TRACE_TAG_AIDL);

        final boolean hasFullyQualifiedName = getMaxTransactionId() > 0;

        final String transactionTraceName;

        if (tagEnabled) {



        if (tagEnabled && hasFullyQualifiedName) {

            // If tracing enabled and we have a fully qualified name, fetch the name

            transactionTraceName = getTransactionTraceName(code);

        } else if (tagEnabled && isStackTrackingEnabled()) {

            // If tracing is enabled and we *don't* have a fully qualified name, fetch the

            // 'best effort' name only for stack tracking. This works around noticeable perf impact

            // on low latency binder calls (<100us). The tracing call itself is between (1-10us) and

            // the perf impact can be quite noticeable while benchmarking such binder calls.

            // The primary culprits are ContentProviders and Cursors which convenienty don't

            // autogenerate their AIDL and hence will not have a fully qualified name.

            //

            // TODO(b/253426478): Relax this constraint after a more robust fix

            transactionTraceName = getTransactionTraceName(code);

        } else {

            transactionTraceName = null;