Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0cec72f authored by Adrian Roos's avatar Adrian Roos
Browse files

fw/base: work around mockito upgrade issues 

- b/397768983: Force the SAM conversion because kotlinc 1.9 does not reliably pick the intended overload
- b/397769063: Work around bug in CachedAppOptimizer that newly gets detected by existing test

Test: atest com.android.systemui.stylus.StylusManagerTest com.andorid.server.am.CachedAppOptimizerTest
Flag: TEST_ONLY
Change-Id: Ib6eacfefe72357db42cddd6f2e720cd81d95d360
parent 8f4a29b4

packages/SystemUI/tests/src/com/android/systemui/stylus/StylusManagerTest.kt

+4 −3
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ import com.android.dx.mockito.inline.extended.ExtendedMockito.mockitoSession 
import com.android.dx.mockito.inline.extended.ExtendedMockito.never

import com.android.dx.mockito.inline.extended.ExtendedMockito.times

import com.android.dx.mockito.inline.extended.ExtendedMockito.verify

import com.android.dx.mockito.inline.extended.MockedVoidMethod

import com.android.dx.mockito.inline.extended.StaticMockitoSession

import com.android.internal.logging.InstanceId

import com.android.internal.logging.UiEventLogger
@@ -246,7 +247,7 @@ class StylusManagerTest : SysuiTestCase() { 
    @Test

    fun onInputDeviceAdded_btStylus_firstUsed_setsFlag() {

        stylusManager.onInputDeviceAdded(BT_STYLUS_DEVICE_ID)

        verify({ InputSettings.setStylusEverUsed(mContext, true) }, times(1))

        verify(MockedVoidMethod { InputSettings.setStylusEverUsed(mContext, true) }, times(1))

    }



    @Test
@@ -512,7 +513,7 @@ class StylusManagerTest : SysuiTestCase() { 


        stylusManager.onBatteryStateChanged(STYLUS_DEVICE_ID, 1, batteryState)



        verify({ InputSettings.setStylusEverUsed(mContext, true) }, times(1))

        verify(MockedVoidMethod { InputSettings.setStylusEverUsed(mContext, true) }, times(1))

    }



    @Test
@@ -613,7 +614,7 @@ class StylusManagerTest : SysuiTestCase() { 


        stylusManager.onBatteryStateChanged(STYLUS_DEVICE_ID, 1, batteryState)



        verify({ InputSettings.setStylusEverUsed(mContext, true) }, never())

        verify(MockedVoidMethod { InputSettings.setStylusEverUsed(mContext, true) }, never())

    }



    @Test

services/tests/mockingservicestests/src/com/android/server/am/CachedAppOptimizerTest.java

+6 −6
Original line number Diff line number Diff line
@@ -372,6 +372,12 @@ public final class CachedAppOptimizerTest { 


        // When we override new reasonable throttle values after init...

        mCountDown = new CountDownLatch(8);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_ACTIVITY_MANAGER,

                CachedAppOptimizer.KEY_COMPACT_THROTTLE_MIN_OOM_ADJ,

                Long.toString(CachedAppOptimizer.DEFAULT_COMPACT_THROTTLE_MIN_OOM_ADJ + 1), false);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_ACTIVITY_MANAGER,

                CachedAppOptimizer.KEY_COMPACT_THROTTLE_MAX_OOM_ADJ,

                Long.toString(CachedAppOptimizer.DEFAULT_COMPACT_THROTTLE_MAX_OOM_ADJ - 1), false);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_ACTIVITY_MANAGER,

                CachedAppOptimizer.KEY_COMPACT_THROTTLE_1,

                Long.toString(CachedAppOptimizer.DEFAULT_COMPACT_THROTTLE_1 + 1), false);
@@ -390,12 +396,6 @@ public final class CachedAppOptimizerTest { 
        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_ACTIVITY_MANAGER,

                CachedAppOptimizer.KEY_COMPACT_THROTTLE_6,

                Long.toString(CachedAppOptimizer.DEFAULT_COMPACT_THROTTLE_6 + 1), false);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_ACTIVITY_MANAGER,

                CachedAppOptimizer.KEY_COMPACT_THROTTLE_MIN_OOM_ADJ,

                Long.toString(CachedAppOptimizer.DEFAULT_COMPACT_THROTTLE_MIN_OOM_ADJ + 1), false);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_ACTIVITY_MANAGER,

                CachedAppOptimizer.KEY_COMPACT_THROTTLE_MAX_OOM_ADJ,

                Long.toString(CachedAppOptimizer.DEFAULT_COMPACT_THROTTLE_MAX_OOM_ADJ - 1), false);

        assertThat(mCountDown.await(7, TimeUnit.SECONDS)).isTrue();



        // Then those flags values are reflected in the compactor.