Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efb63a7c authored by Grace Jia's avatar Grace Jia
Browse files

Address StreamingCall API review comments. 

Rename setStreamingState to requestStreamingState

Bug: 266079693
Test: build
Change-Id: Ide4dc11efb3da47f4c238121672d19ca98023778
parent e7a8a48f

core/api/current.txt

+1 −1
Original line number Diff line number Diff line
@@ -42175,7 +42175,7 @@ package android.telecom { 
    method @NonNull public String getDisplayName();

    method @NonNull public android.os.Bundle getExtras();

    method public int getState();

    method public void setStreamingState(int);

    method public void requestStreamingState(int);

    method public void writeToParcel(@NonNull android.os.Parcel, int);

    field @NonNull public static final android.os.Parcelable.Creator<android.telecom.StreamingCall> CREATOR;

    field public static final int STATE_DISCONNECTED = 3; // 0x3

telecomm/java/android/telecom/CallStreamingService.java

+1 −1
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ public abstract class CallStreamingService extends Service { 
                    break;

                case MSG_CALL_STREAMING_CHANGED_CHANGED:

                    int state = (int) msg.obj;

                    mCall.setStreamingState(state);

                    mCall.requestStreamingState(state);

                    CallStreamingService.this.onCallStreamingStateChanged(state);

                    break;

                default:

telecomm/java/android/telecom/StreamingCall.java

+1 −1
Original line number Diff line number Diff line
@@ -172,7 +172,7 @@ public final class StreamingCall implements Parcelable { 
     * to request holding, unholding and disconnecting this {@code StreamingCall}.

     * @param state The current streaming state of the call.

     */

    public void setStreamingState(@StreamingCallState int state) {

    public void requestStreamingState(@StreamingCallState int state) {

        mAdapter.setStreamingState(state);

    }

}

telecomm/java/android/telecom/StreamingCallAdapter.java

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ import com.android.internal.telecom.IStreamingCallAdapter; 
 * Telecom. When Telecom binds to a {@link CallStreamingService}, an instance of this class is given

 * to the general streaming app through which it can manipulate the streaming calls. Whe the general

 * streaming app is notified of new ongoing streaming calls, it can execute

 * {@link StreamingCall#setStreamingState(int)} for the ongoing streaming calls the user on the

 * {@link StreamingCall#requestStreamingState(int)} for the ongoing streaming calls the user on the

 * receiver side would like to hold, unhold and disconnect.

 *

 * @hide