Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef6da8fe authored by Leon Scroggins's avatar Leon Scroggins
Browse files

Make clicking the trackball on a <select> element work. 

Optionally pass a frame and node pointer to nativeClick, since
the hit testing does not find the HTMLSelectElement node. Also
change the signature of nativeClick to return void, since
we never use the return value.  Requires a change in
external/webkit.
parent 53d3c1e4

core/java/android/webkit/WebView.java

+4 −3
Original line number Diff line number Diff line
@@ -4677,13 +4677,14 @@ public class WebView extends AbsoluteLayout 
                        break;

                    }

                    nativeSetFollowedLink(true);

                    mWebViewCore.sendMessage(EventHub.SET_MOVE_MOUSE,

                            cursorData());

                    WebViewCore.CursorData data = cursorData();

                    mWebViewCore.sendMessage(EventHub.SET_MOVE_MOUSE, data);

                    playSoundEffect(SoundEffectConstants.CLICK);

                    boolean isTextInput = nativeCursorIsTextInput();

                    if (isTextInput || !mCallbackProxy.uiOverrideUrlLoading(

                                nativeCursorText())) {

                        mWebViewCore.sendMessage(EventHub.CLICK);

                        mWebViewCore.sendMessage(EventHub.CLICK, data.mFrame,

                                nativeCursorNodePointer());

                    }

                    if (isTextInput) {

                        rebuildWebTextView();

core/java/android/webkit/WebViewCore.java

+2 −2
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ final class WebViewCore { 
    private native boolean nativeKey(int keyCode, int unichar,

            int repeatCount, boolean isShift, boolean isAlt, boolean isDown);



    private native boolean nativeClick();

    private native void nativeClick(int framePtr, int nodePtr);



    private native void nativeSendListBoxChoices(boolean[] choices, int size);
@@ -803,7 +803,7 @@ final class WebViewCore { 
                            break;



                        case CLICK:

                            nativeClick();

                            nativeClick(msg.arg1, msg.arg2);

                            break;



                        case VIEW_SIZE_CHANGED: