Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef6a0294 authored by Winson Chiu's avatar Winson Chiu Committed by Automerger Merge Worker
Browse files

Merge "Generalize canPackageQuery error message" into tm-dev am: 96ad5cca 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18358288



Change-Id: I6720a3339a0820cbb6e3fac87f42d81c0249329f
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 73f2d83f 96ad5cca

services/core/java/com/android/server/pm/ComputerEngine.java

+11 −15
Original line number Diff line number Diff line
@@ -5443,22 +5443,18 @@ public class ComputerEngine implements Computer { 
                false /*checkShell*/, "may package query");

        final PackageStateInternal sourceSetting = getPackageStateInternal(sourcePackageName);

        final PackageStateInternal targetSetting = getPackageStateInternal(targetPackageName);

        if (sourceSetting == null || targetSetting == null) {

            throw new ParcelableException(new PackageManager.NameNotFoundException("Package(s) "

                    + (sourceSetting == null ? sourcePackageName + " " : "")

                    + (targetSetting == null ? targetPackageName + " " : "")

                    + "not found."));

        }

        boolean throwException = sourceSetting == null || targetSetting == null;

        if (!throwException) {

            final boolean filterSource =

                    shouldFilterApplication(sourceSetting, callingUid, userId);

            final boolean filterTarget =

                    shouldFilterApplication(targetSetting, callingUid, userId);

            // The caller must have visibility of the both packages

        if (filterSource || filterTarget) {

            throwException = filterSource || filterTarget;

        }

        if (throwException) {

            throw new ParcelableException(new PackageManager.NameNotFoundException("Package(s) "

                    + (filterSource ? sourcePackageName + " " : "")

                    + (filterTarget ? targetPackageName + " " : "")

                    + "not found."));

                    + sourcePackageName + " and/or " + targetPackageName + " not found."));

        }

        final int sourcePackageUid = UserHandle.getUid(userId, sourceSetting.getAppId());

        return !shouldFilterApplication(targetSetting, sourcePackageUid, userId);