Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef1c687d authored by Matt Casey's avatar Matt Casey
Browse files

Remove drop shadow from corner handles. 

Ran into some visual issues with it, reverting to old treatment for now.

Bug: 144022299
Test: Visual verification
Change-Id: Id9370b5cef8dbc032791d36192ddbe285a790a9e
parent e6c57082

core/res/res/values/dimens.xml

+0 −3
Original line number Diff line number Diff line
@@ -780,9 +780,6 @@ 


    <dimen name="chooser_action_button_icon_size">18dp</dimen>



    <!-- Assistant handles -->

    <dimen name="assist_handle_shadow_radius">2dp</dimen>



    <!-- For Waterfall Display -->

    <dimen name="waterfall_display_left_edge_size">0px</dimen>

    <dimen name="waterfall_display_top_edge_size">0px</dimen>

core/res/res/values/symbols.xml

+0 −3
Original line number Diff line number Diff line
@@ -3844,9 +3844,6 @@ 
  <!-- For App Standby -->

  <java-symbol type="string" name="as_app_forced_to_restricted_bucket" />



  <!-- Assistant handles -->

  <java-symbol type="dimen" name="assist_handle_shadow_radius" />



  <!-- For Waterfall Display -->

  <java-symbol type="dimen" name="waterfall_display_left_edge_size" />

  <java-symbol type="dimen" name="waterfall_display_top_edge_size" />

packages/SystemUI/src/com/android/systemui/CornerHandleView.java

+0 −7
Original line number Diff line number Diff line
@@ -57,7 +57,6 @@ public class CornerHandleView extends View { 
        mPaint.setStyle(Paint.Style.STROKE);

        mPaint.setStrokeCap(Paint.Cap.ROUND);

        mPaint.setStrokeWidth(getStrokePx());

        setLayerType(View.LAYER_TYPE_SOFTWARE, mPaint);



        final int dualToneDarkTheme = Utils.getThemeAttr(mContext, R.attr.darkIconTheme);

        final int dualToneLightTheme = Utils.getThemeAttr(mContext, R.attr.lightIconTheme);
@@ -118,14 +117,8 @@ public class CornerHandleView extends View { 
        // Handle color is same as home handle color.

        int color = (int) ArgbEvaluator.getInstance().evaluate(darkIntensity,

                mLightColor, mDarkColor);

        // Shadow color is inverse of handle color.

        int shadowColor = (int) ArgbEvaluator.getInstance().evaluate(darkIntensity,

                mDarkColor, mLightColor);

        if (mPaint.getColor() != color) {

            mPaint.setColor(color);

            mPaint.setShadowLayer(/** radius */ getResources().getDimensionPixelSize(

                    com.android.internal.R.dimen.assist_handle_shadow_radius), /** shadowDx */ 0,

                    /** shadowDy */ 0, /** color */ shadowColor);

            if (getVisibility() == VISIBLE && getAlpha() > 0) {

                invalidate();

            } else {