Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eee930b9 authored by Pablo Gamito's avatar Pablo Gamito
Browse files

Remove expensive trace call in ProtoLog log call 

Test: protolog benchmark tests
Flag: NONE deleting tracing code
Change-Id: I9b97d19e6e62490e1b93eb82900f19750265e7b0
parent 4f5f0050

core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java

+15 −27
Original line number Diff line number Diff line
@@ -156,9 +156,6 @@ public class PerfettoProtoLogImpl implements IProtoLog { 
    @Override

    public void log(LogLevel level, IProtoLogGroup group, long messageHash, int paramsMask,

            @Nullable Object[] args) {

        Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "log");



        try {

        if (isProtoEnabled()) {

            long tsNanos = SystemClock.elapsedRealtimeNanos();

            mBackgroundLoggingService.execute(() ->
@@ -167,16 +164,10 @@ public class PerfettoProtoLogImpl implements IProtoLog { 
        if (group.isLogToLogcat()) {

            logToLogcat(group.getTag(), level, messageHash, args);

        }

        } finally {

            Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);

        }

    }



    @Override

    public void log(LogLevel logLevel, IProtoLogGroup group, String messageString, Object... args) {

        Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "log");



        try {

        if (isProtoEnabled()) {

            long tsNanos = SystemClock.elapsedRealtimeNanos();

            mBackgroundLoggingService.execute(
@@ -186,9 +177,6 @@ public class PerfettoProtoLogImpl implements IProtoLog { 
        if (group.isLogToLogcat()) {

            logToLogcat(group.getTag(), logLevel, messageString, args);

        }

        } finally {

            Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);

        }

    }



    private void dumpTransitionTraceConfig() {