Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eea2353a authored by Christopher Wiley's avatar Christopher Wiley
Browse files

Tighten up compiler flags for aidl 

Turn all warnings to errors, with special cases for places where
yacc forces us to be lenient.  Remove one variable with 0 references
elsewhere in the code.

Change-Id: Ia7819795eb162e9c77d215088aee4c45bd87c1af
parent 3fc6f441

tools/aidl/Android.mk

+11 −1
Original line number Diff line number Diff line
@@ -8,6 +8,17 @@ ifeq ($(TARGET_BUILD_APPS)$(filter true,$(TARGET_BUILD_PDK)),) 
LOCAL_PATH:= $(call my-dir)

include $(CLEAR_VARS)



LOCAL_CFLAGS := -g -Wall -Werror

# Tragically, the code is riddled with unused parameters.

LOCAL_CFLAGS += -Wno-unused-parameter

# yacc dumps a lot of code *just in case*.

LOCAL_CFLAGS += -Wno-unused-function

LOCAL_CFLAGS += -Wno-unneeded-internal-declaration

# yacc is a tool from a more civilized age.

LOCAL_CFLAGS += -Wno-deprecated-register

# yacc also has a habit of using char* over const char*.

LOCAL_CFLAGS += -Wno-writable-strings



LOCAL_SRC_FILES := \

	aidl_language_l.l \

	aidl_language_y.y \
@@ -21,7 +32,6 @@ LOCAL_SRC_FILES := \ 
	generate_java_binder.cpp \

	generate_java_rpc.cpp



LOCAL_CFLAGS := -g

LOCAL_MODULE := aidl



include $(BUILD_HOST_EXECUTABLE)

tools/aidl/aidl.cpp

+0 −5
Original line number Diff line number Diff line
@@ -165,11 +165,6 @@ import_import_parsed(buffer_type* statement) 
{

}



static ParserCallbacks g_importCallbacks = {

    &main_document_parsed,

    &import_import_parsed

};



// ==========================================================

static int

check_filename(const char* filename, const char* package, buffer_type* name)