Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee9fd2d6 authored by Paul Duffin's avatar Paul Duffin Committed by Automerger Merge Worker
Browse files

Fix lint errors in tools/hiddenapi am: f16a93c5 am: 5705a1f7 am: 80167cbe am: 9578eebd 

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1580532

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Icb7bb39eebe89afb3e5ad0d7f7d4730457d2bfe8
parents 483a91bc 9578eebd

tools/hiddenapi/generate_hiddenapi_lists.py

+1 −1
Original line number Diff line number Diff line
@@ -153,7 +153,7 @@ def write_lines(filename, lines): 
    """Writes list of lines into a file, overwriting the file if it exists.



    Args:

        filename (string): Path to the file to be writting into.

        filename (string): Path to the file to be writing into.

        lines (list): List of strings to write into the file.

    """

    lines = map(lambda line: line + '\n', lines)

tools/hiddenapi/generate_hiddenapi_lists_test.py

+2 −2
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ from generate_hiddenapi_lists import * 
class TestHiddenapiListGeneration(unittest.TestCase):



    def test_filter_apis(self):

        # Initialize flags so that A and B are put on the whitelist and

        # Initialize flags so that A and B are put on the allow list and

        # C, D, E are left unassigned. Try filtering for the unassigned ones.

        flags = FlagsDict()

        flags.parse_and_merge_csv(['A,' + FLAG_SDK, 'B,' + FLAG_SDK,
@@ -39,7 +39,7 @@ class TestHiddenapiListGeneration(unittest.TestCase): 


        # Check three things:

        # (1) B is selected as valid unassigned

        # (2) A is not selected because it is assigned 'whitelist'

        # (2) A is not selected because it is assigned to the allow list

        # (3) D is not selected because it is not a valid key

        self.assertEqual(

            flags.get_valid_subset_of_unassigned_apis(set(['A', 'B', 'D'])), set([ 'B' ]))