Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee609ff1 authored by Hall Liu's avatar Hall Liu
Browse files

API tweaks 

* Make the PhoneAccountSuggestion ctor public
* Change protection level of the bind-suggestion-service permission to
signature-only.

Fixes: 126442573
Fixes: 126442403
Test: CTS
Change-Id: Ic6d44989efd28420a5e9e7e9c365318538d140bb
parent d14d29ca

api/current.txt

+1 −0
Original line number Diff line number Diff line
@@ -41736,6 +41736,7 @@ package android.telecom { 
  }















  public final class PhoneAccountSuggestion implements android.os.Parcelable {













    ctor public PhoneAccountSuggestion(@NonNull android.telecom.PhoneAccountHandle, int, boolean);















    method public int describeContents();















    method @NonNull public android.telecom.PhoneAccountHandle getPhoneAccountHandle();















    method public int getReason();

























api/system-current.txt



+0
−4




























Original line number
Diff line number
Diff line








@@ -5412,10 +5412,6 @@ package android.telecom {













    field public static final int CAPABILITY_MULTI_USER = 32; // 0x20















  }



























  public final class PhoneAccountSuggestion implements android.os.Parcelable {













    ctor public PhoneAccountSuggestion(@NonNull android.telecom.PhoneAccountHandle, int, boolean);













  }



























  public class PhoneAccountSuggestionService extends android.app.Service {















    ctor public PhoneAccountSuggestionService();















    method public void onAccountSuggestionRequest(@NonNull String);

































api/test-current.txt



+0
−4




























Original line number
Diff line number
Diff line








@@ -1443,10 +1443,6 @@ package android.telecom {













    method public android.telecom.Connection getPrimaryConnection();















  }





























  public final class PhoneAccountSuggestion implements android.os.Parcelable {













    ctor public PhoneAccountSuggestion(@NonNull android.telecom.PhoneAccountHandle, int, boolean);













  }





























  public class PhoneAccountSuggestionService extends android.app.Service {















    ctor public PhoneAccountSuggestionService();















    method public void onAccountSuggestionRequest(@NonNull String);

































core/res/AndroidManifest.xml



+2
−2




























Original line number
Diff line number
Diff line








@@ -1839,12 +1839,12 @@





























    <!-- Must be required by a {@link android.telecom.PhoneAccountSuggestionService},















         to ensure that only the system can bind to it.













         <p>Protection level: signature|privileged













         <p>Protection level: signature















         @SystemApi















         @hide















    -->















    <permission android:name="android.permission.BIND_PHONE_ACCOUNT_SUGGESTION_SERVICE"













        android:protectionLevel="signature|privileged" />













        android:protectionLevel="signature" />































    <!-- Must be required by a {@link android.telecom.CallRedirectionService},















         to ensure that only the system can bind to it.

































telecomm/java/android/telecom/PhoneAccountSuggestion.java



+8
−5




























Original line number
Diff line number
Diff line








@@ -18,8 +18,6 @@ package android.telecom;





























import android.annotation.IntDef;















import android.annotation.NonNull;













import android.annotation.SystemApi;













import android.annotation.TestApi;















import android.os.Parcel;















import android.os.Parcelable;


























@@ -69,10 +67,15 @@ public final class PhoneAccountSuggestion implements Parcelable {













    private boolean mShouldAutoSelect;































    /**













     * @hide













     * Creates a new instance of {@link PhoneAccountSuggestion}. This constructor is intended for













     * use by apps implementing a {@link PhoneAccountSuggestionService}, and generally should not be













     * used by dialer apps other than for testing purposes.













     *













     * @param handle The {@link PhoneAccountHandle} for this suggestion.













     * @param reason The reason for this suggestion













     * @param shouldAutoSelect Whether the dialer should automatically place the call using this













     *                         account. See {@link #shouldAutoSelect()}.















     */













    @SystemApi













    @TestApi















    public PhoneAccountSuggestion(@NonNull PhoneAccountHandle handle, @SuggestionReason int reason,















            boolean shouldAutoSelect) {















        this.mHandle = handle;