Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee23f597 authored by Beverly's avatar Beverly
Browse files

SFPS indicator becomes visibile after position is ready 

Don't set the visibility of the SFPS indicator to VISIBLE
until after the window parameters of the view are set.
This prevents a flash of the view being in the wrong location.

We also update repeatOnLifecycle(STARTED) to CREATED
so that we are able to collect the window params before
the view is visible.

Flag: EXEMPT bugfix
Test: enroll sideFP, show bouncer on lockscreen,
observe correct position of SFPS indicator (no flash
of it being in the wrong place)
Fixes: 398820784

Change-Id: Ia27905072b3bfcdd86e18a8a3c86e30692778b53
parent 437af864

packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/SideFpsOverlayViewBinder.kt

+2 −2
Original line number Diff line number Diff line
@@ -222,7 +222,6 @@ constructor( 
                lottie.addLottieOnCompositionLoadedListener { composition: LottieComposition ->

                    if (overlayView.visibility != View.VISIBLE) {

                        viewModel.setLottieBounds(composition.bounds)

                        overlayView.visibility = View.VISIBLE

                    }

                }

                it.alpha = 0f
@@ -234,7 +233,7 @@ constructor( 


                overlayShowAnimator.start()



                repeatOnLifecycle(Lifecycle.State.STARTED) {

                repeatOnLifecycle(Lifecycle.State.CREATED) {

                    launch {

                        viewModel.lottieCallbacks.collect { callbacks ->

                            lottie.addOverlayDynamicColor(callbacks)
@@ -245,6 +244,7 @@ constructor( 
                        viewModel.overlayViewParams.collect { params ->

                            windowManager.updateViewLayout(it, params)

                            lottie.resumeAnimation()

                            overlayView.visibility = View.VISIBLE

                        }

                    }